Skip to content

feat(mobile): rename sessions from detail title#4589

Merged
iscekic merged 1 commit into
mainfrom
feature/mobile-session-title-rename
Jul 16, 2026
Merged

feat(mobile): rename sessions from detail title#4589
iscekic merged 1 commit into
mainfrom
feature/mobile-session-title-rename

Conversation

@iscekic

@iscekic iscekic commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make a loaded session detail title tappable and open the shared rename modal
  • reuse the existing session rename mutation for optimistic list/header updates, rollback, retry feedback, and serialization
  • add reducer and mutation coverage for loading, success, failure, repeated renames, and session changes

Verification

  • pnpm test (129 files, 841 tests)
  • pnpm typecheck
  • pnpm lint
  • pnpm check:unused
  • pnpm format:check
  • git diff --check
  • iOS simulator: title tap, modal prefill/save, header/list persistence, reopen persistence, and cancel/reset passed before the final rollback-only repair
  • latest-diff repeat E2E was blocked before feature interaction by the local post-OTP simulator state on two clean claimed devices; the final repair is covered by the repeated-rename regression test

@iscekic iscekic self-assigned this Jul 16, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the mobile session-title-rename feature (reducer, hook, mutation, and header wiring) and found no correctness, security, or reliability issues in the changed lines.

Files Reviewed (7 files)
  • apps/mobile/src/components/agents/session-detail-content.tsx
  • apps/mobile/src/components/agents/session-detail-rename-state.ts
  • apps/mobile/src/components/agents/session-detail-rename-state.test.ts
  • apps/mobile/src/components/agents/use-session-detail-rename.ts
  • apps/mobile/src/components/screen-header.tsx
  • apps/mobile/src/lib/hooks/use-session-mutations.ts
  • apps/mobile/src/lib/hooks/use-session-mutations.test.ts

Reviewed by claude-sonnet-5 · Input: 48 · Output: 7.6K · Cached: 1.3M

Review guidance: REVIEW.md from base branch main

@iscekic iscekic merged commit 6898716 into main Jul 16, 2026
19 checks passed
@iscekic iscekic deleted the feature/mobile-session-title-rename branch July 16, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants