Skip to content

test(kiloclaw): add edge-case coverage for rolloutBucket #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
St0rmz1 wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

test(kiloclaw): add edge-case coverage for rolloutBucket #4597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions services/kiloclaw/src/lib/rollout-bucket.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,26 @@ describe('rolloutBucket', () => {
expect(ratio).toBeLessThan(0.55);
});

it('handles an empty key', async () => {
const v = await rolloutBucket('');
expect(v).toBeGreaterThanOrEqual(0);
expect(v).toBeLessThanOrEqual(99);
});

it('handles non-ASCII keys', async () => {
const v = await rolloutBucket('instance:café-日本語-🦀');
expect(v).toBeGreaterThanOrEqual(0);
expect(v).toBeLessThanOrEqual(99);
});

it('is sensitive to key ordering, not just content', async () => {
// Guards against a keying scheme where concatenation could collide, e.g.
// `tag:ab` + `instance:c` landing in the same bucket as `tag:a` + `instance:bc`.
const a = await rolloutBucket('tag:ab:instance:c');
const b = await rolloutBucket('tag:a:instance:bc');
expect(a).not.toBe(b);
});

it('changes the bucket for a fixed instanceId when the salt (imageTag) changes', async () => {
const instanceId = '550e8400-e29b-41d4-a716-446655440001';
const a = await rolloutBucket(`tag:kiloclaw-2026.4.23-aaa:instance:${instanceId}`);
Expand Down