fix(gitlab): accept project lookup metadata#4635
Merged
eshurakov merged 1 commit intoJul 20, 2026
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the GitLab project identity schema relaxation and its test update; the change correctly loosens Files Reviewed (2 files)
Reviewed by claude-sonnet-5 · Input: 14 · Output: 2.4K · Cached: 237.2K Review guidance: REVIEW.md from base branch |
jeanduplessis
approved these changes
Jul 20, 2026
eshurakov
deleted the
eshurakov/git-token-service-accept-gitlab-project-fields
branch
July 20, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow GitLab project lookup responses to include standard metadata while continuing to require a valid positive project ID.
Add regression coverage for a representative GitLab project response.
Verification
Visual Changes
N/A
Reviewer Notes
The identity parser now ignores non-identity response fields rather than rejecting the entire GitLab API response.