Skip to content

fix(gitlab): accept project lookup metadata#4635

Merged
eshurakov merged 1 commit into
mainfrom
eshurakov/git-token-service-accept-gitlab-project-fields
Jul 20, 2026
Merged

fix(gitlab): accept project lookup metadata#4635
eshurakov merged 1 commit into
mainfrom
eshurakov/git-token-service-accept-gitlab-project-fields

Conversation

@eshurakov

Copy link
Copy Markdown
Contributor

Summary

Allow GitLab project lookup responses to include standard metadata while continuing to require a valid positive project ID.

Add regression coverage for a representative GitLab project response.

Verification

  • Manual testing not run; this is a non-UI resolver change covered by focused automated checks.

Visual Changes

N/A

Reviewer Notes

The identity parser now ignores non-identity response fields rather than rejecting the entire GitLab API response.

@kilo-code-bot

kilo-code-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the GitLab project identity schema relaxation and its test update; the change correctly loosens .strict() while still validating id as a positive integer, with no security, correctness, or reliability issues found.

Files Reviewed (2 files)
  • services/git-token-service/src/gitlab-runtime-token-resolver.ts
  • services/git-token-service/src/index.test.ts

Reviewed by claude-sonnet-5 · Input: 14 · Output: 2.4K · Cached: 237.2K

Review guidance: REVIEW.md from base branch main

@eshurakov
eshurakov merged commit e9664bb into main Jul 20, 2026
15 checks passed
@eshurakov
eshurakov deleted the eshurakov/git-token-service-accept-gitlab-project-fields branch July 20, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants