feat: promote sandbox configuration#12049
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Reviewed the incremental change since the last commit: a documentation-only follow-up to Verified each rewritten claim against the implementation: The remaining human review comments on Files Reviewed (1 file, incremental since last review)
Previous Review Summaries (3 snapshots, latest commit 5697e71)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 5697e71)Status: No Issues Found | Recommendation: Merge Reviewed the incremental change since the last commit: a single wording fix in the sandboxing docs ("outside the project" -> "outside the workspace"), addressing a reviewer's open question about accuracy. No new code, logic, or config changes were introduced. The remaining human review comments on Files Reviewed (1 file, incremental since last review)
Previous review (commit 4ebfea8)Status: No Issues Found | Recommendation: Merge Reviewed the incremental changes since the last commit: sandboxing is promoted from Files Reviewed (33 files, incremental since last review)
Previous review (commit cd9229b)Status: No Issues Found | Recommendation: Merge Reviewed the platform-gating change ( Files Reviewed (11 files)
Reviewed by claude-sonnet-5-20260630 · Input: 50 · Output: 13.6K · Cached: 1.2M Review guidance: REVIEW.md from base branch |
cd9229b to
fe7eff7
Compare
lambertjosh
left a comment
There was a problem hiding this comment.
Approved for docs, minor comments
Co-authored-by: Joshua Lambert <25085430+lambertjosh@users.noreply.github.com>
Sandboxing was exposed through experimental configuration fields and an enable switch separated from its dedicated settings page. That made a release-ready security control difficult to discover and left its public config, SDK types, and documentation framed as experimental.
This promotes sandboxing to a first-class
sandboxobject withenabled,network, andwritable_pathssettings. It remains disabled by default. Global config defines the baseline; project config may enable sandboxing or deny network access, but cannot weaken global policy or add writable paths. The retired experimental keys are removed rather than migrated.The VS Code Sandboxing page is visible on supported macOS and Linux hosts, owns the global enable setting, and disables network and writable-path controls until sandboxing is enabled. Windows continues to hide unsupported controls.
The documentation now explains the filesystem and network boundaries, how permissions complement sandboxing, and the prompt-injection, provider-privacy, MCP, plugin, and policy-integrity limits users need when choosing a security setup. Public SDK and OpenAPI config types expose the stable object.
Visual baseline automation now checks out LFS data with a read-only workflow token and uses the Kilo Maintainer App only when a generated baseline commit is required. This replaces the stale PAT path that prevented regeneration.
Companion hosted config-schema update: Kilo-Org/cloud#4462