issue#4: branch 'iss4_ljs'#14
Conversation
… to related operations and parameter passing.
Kimhyewon0621
left a comment
Kimhyewon0621
left a comment
There was a problem hiding this comment.
YOur code looks good to me!!! However there are a littlei issue?. I want to keep UI consistency. So After our project will be ready perfectly than make an issue for that problem~
AyeongKwon
left a comment
AyeongKwon
left a comment
There was a problem hiding this comment.
Thank you for your hard work...!
LGTM!💘
| if (listType.equals("1")) target = mandatory; | ||
| else if (listType.equals("2")) target = optional; | ||
| else { | ||
| System.out.println("Canceled."); |
There was a problem hiding this comment.
This would be typo.
I think this is not precious,but just want to notify you.
There was a problem hiding this comment.
Oh! Thanks for notifying me I'll fix it!
mingyeonggg
left a comment
mingyeonggg
left a comment
There was a problem hiding this comment.
Great job!! I just leave a suggestion. Please check it~
| nextInput = rv.printBatchAndGetInput(this.schedules, index, this.sc); | ||
|
|
||
| if (nextInput.equals("next")) { | ||
| index += 5; |
There was a problem hiding this comment.
Nice work on this feature! 🤩
However, I just found out a critical bug:
The code increases index by 5 without checking the list size. If the user keeps typing "next" after the last page, this will definitely cause an IndexOutOfBoundsException.
Please add a validation check (e.g., if (index + 5 < schedules.size())) before increasing the index to prevent this critical crash.
There was a problem hiding this comment.
😯Thanks for the critical detail! I'll fix before merging it.
4 participants
Issue #4
Summary:
Adds post-actions:
Notes: