Skip to content

Issue#1: branch 'iss1_ljs'#7

Merged
ljseop1030 merged 8 commits into
mainfrom
iss1_ljs
Dec 5, 2025
Merged

Issue#1: branch 'iss1_ljs'#7
ljseop1030 merged 8 commits into
mainfrom
iss1_ljs

Conversation

@ljseop1030

Copy link
Copy Markdown
Collaborator

Issue

#1 handled

Summary

This implements the initial input system for UniTime-Solver.
Users can enter the maximum credit, mandatory courses, and optional courses, which are then stored and accessible through getters.

  • Added 'Course' class and 'CourseTest'
  • Added 'InputHandler' class - manually tested basic input cases
  • Core features are made (for the other issues), and additional details will be implemented later.

Changes

  1. Course class: Stores individual course information
    Added fields for name, credit, day, start time, and end time
    Added getters(getName, getDay, getCredit, getStartTime, getEndTime, getTimeRaw) and toString() for safe data use.

  2. InputHandler class: Console input system
    main: handles user input flow and prints a final summary
    inputLoop: validates and parses course input, then adds it to the list
    parseMin: converts "HH:MM" into minutes with validation
    Added getters (getMandatoryList, getOptionalList, getMaxCredit) to access parsed data from other modules

@ljseop1030 ljseop1030 self-assigned this Dec 5, 2025

@Kimhyewon0621 Kimhyewon0621 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great To Me!
The core logic and input validation are very well implemented. Since I'm in charge of the UI, I plan to open a new issue later to unify the input interface with the overall UI design. I'll handle the UI integration in that upcoming issue. Great job!

@ljseop1030 ljseop1030 requested a review from AyeongKwon December 5, 2025 13:29
Comment thread src/main/java/com/unitime/feature/Course.java Outdated
Co-authored-by: AyeongKwon <zero523@seoultech.ac.kr>

@mingyeonggg mingyeonggg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! I just left one small comment to improve the UX. Other than that, everything looks perfect.

Comment thread src/main/java/com/unitime/feature/InputHandler.java
@ljseop1030 ljseop1030 requested a review from AyeongKwon December 5, 2025 16:03

@AyeongKwon AyeongKwon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the quick fix.

Comment thread src/main/java/com/unitime/feature/Course.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants