Issue#2: Implement Scheduler algorithm#9
Merged
Merged
Conversation
mingyeonggg
changed the title
AyeongKwon
approved these changes
Dec 11, 2025
AyeongKwon
left a comment
AyeongKwon
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me!! 😎
Very nice logic to implement scheduling algorithm!
ljseop1030
reviewed
Dec 11, 2025
Kimhyewon0621
approved these changes
Dec 11, 2025
Kimhyewon0621
left a comment
Kimhyewon0621
left a comment
Owner
There was a problem hiding this comment.
To make these tests easier to understand for other people, could you add some comments explaining the scenario for each test?
For example, in testTimeConflict, a comment like
// Verifying that a course with overlapping time is NOT added
Collaborator
Author
|
Hello Hyewon! |
ljseop1030
approved these changes
Dec 11, 2025
Owner
|
I check your comments! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented logic to generate timetables by combining mandatory and optional courses, and added unit tests.