Create rename milestone github action#296
Merged
Merged
Conversation
CalvinWilkinson
added
the
area:actions
BREAKING CHANGE
There was a problem hiding this comment.
Pull request overview
Adds a new rename-milestone composite GitHub Action (script + action.yml) that renames a GitHub milestone via the REST API. Bundled with that are several broad, unrelated changes: hard-coding deno-version: v2.7.14 across many actions and removing their deno-version input, removing the build_project job from dotnet-action-release.yml, removing the priority-label item from the issue template, reformatting release-notes-generator.ts, switching close-milestone.ts to a renamed client method, and bumping dependencies in deno.lock.
Changes:
- New
actions/rename-milestoneaction (script +action.yml) usingMilestoneClientplus a directPATCHto the GitHub API. - Hard-coded Deno version (
v2.7.14) in ~15 action manifests; removed theirdeno-versioninputs. - Misc unrelated edits: workflow build job removal, issue-template tweak, formatting/style changes, and
deno.lockbumps.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| actions/rename-milestone/action.yml | New action manifest; env vars don't match the script. |
| actions/rename-milestone/rename-milestone.ts | New rename script; reads wrong env var names, bypasses MilestoneClient for the rename. |
| actions/close-milestone/{action.yml,close-milestone.ts} | Switch import to JSR client and rename milestoneExists → exists; pin Deno version. |
| actions/{validate-version,validate-tag,validate-sdk-versions,update-copyright,transpile-readme,send-x-release-announcement,send-bluesky-release-announcement,release-notes-exist,nuget-pkg-exists,milestone-items-closed,milestone-exists,jsr-pkg-exists,github-release-exists,get-version}/action.yml | Drop deno-version input and hard-code v2.7.14; clarify some token descriptions. |
| .github/workflows/dotnet-action-release.yml | Remove build_project job and its dependency from perform_release. |
| .github/ISSUE_TEMPLATE/project-item-issue-template.yml | Remove "Add a priority label" checklist item. |
| dev-tools/core/release-notes-generator.ts | Reformatting only (whitespace/cast formatting). |
| deno.lock | Adds cliffy 1.0.1, std bumps, and @atproto/api@0.19.18. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KinsonDigitalAdmin
approved these changes
May 17, 2026
CalvinWilkinson
added
the
breaking-changes
CalvinWilkinson
added a commit
that referenced
this pull request
May 18, 2026
* Start work for #293 * config: update issue template * docs: improve action input docs * deps: update kd-clients to version v1.0.0-preview.16 * feat: create new action to rename milestones * chore: remove the deno-version inputs to all actions BREAKING CHANGE * refactor: improve code to meet coding standards * deps: update deno lock file * fix: remove job that refers to old non-existent workflow * chore: improve new action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this pull request is to implement the changes described in the linked issue.
This pull request closes #293.
Unrelated Changes
deno-versioninput from all of the custom github actions.Reviewer Notes
Add additional notes about what the reviewer should focus on.