Skip to content

Nom 182 - #10

Draft
TolkienFan17 wants to merge 18 commits into
masterfrom
NOM-182
Draft

Nom 182#10
TolkienFan17 wants to merge 18 commits into
masterfrom
NOM-182

Conversation

@TolkienFan17

Copy link
Copy Markdown
Collaborator

What does this PR accomplish?

Definition of Done

  1. The User Story has and passes all tests with consistent, reproducible results. (80% coverage)

    • How does this story accomplish this?
  2. The User Story conforms to the style guide.

    • How does this story accomplish this?
  3. The User Story contains a basic level of documentation (KDocs, comments, clear variable names, etc.)

    • How does this story accomplish this?
  4. The User Story passes the following checklist from a reviewer:

    • File structure is maintained (e.g., a component goes in the Components folder)

      • How does this story maintain file structure?
    • Confirm that the tests are actually testing the code

      • How does this story ensure that the tests are actually testing the code?
    • Code contains comments that provide a basic understanding of the code

      • How does this story ensure that the codebase contains comments that provide a basic understanding?

Acceptance Criteria

What are the acceptance criteria?

  • How does this story complete the acceptance critera?

@TolkienFan17
TolkienFan17 temporarily deployed to test April 27, 2023 20:11 — with GitHub Actions Inactive
@codecov-commenter

codecov-commenter commented Apr 27, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 44.82% and project coverage change: -0.02 ⚠️

Comparison is base (6bbfeaf) 44.91% compared to head (ebc44d4) 44.89%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
- Coverage     44.91%   44.89%   -0.02%     
- Complexity       16       22       +6     
============================================
  Files            10       11       +1     
  Lines           118      147      +29     
  Branches          8       10       +2     
============================================
+ Hits             53       66      +13     
- Misses           65       80      +15     
- Partials          0        1       +1     
Impacted Files Coverage Δ
...a/nomic/ui/fragments/ConfirmationDialogFragment.kt 44.82% <44.82%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants