Use /config for appdata and /data for media in Docker installs#46
Open
JesseHawkins wants to merge 1 commit into
Open
Use /config for appdata and /data for media in Docker installs#46JesseHawkins wants to merge 1 commit into
JesseHawkins wants to merge 1 commit into
Conversation
|
This would be nice just to avoid extra path mapping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the Docker/container path contract so Muxarr stores its persistent app data under
/configand expects mounted media libraries under/data.That matches the common *arr/TRaSH-style convention where:
/configis application state, database, settings, and keys/datais the shared media/downloads path used by the media stackWhat changed
/data/muxarr.dbto/config/muxarr.db/config/configand/data/configand/dataconsistently/data/muxarr.dbExisting install migration
On startup, if
/config/muxarr.dbdoes not exist but/data/muxarr.dbdoes:/config/muxarr.dbusing SQLite's backup APIPRAGMA quick_check/config/muxarr-previous.dbfor rollbackIf
/config/muxarr.dbalready exists, it is left untouched.Testing
Tested with:
dotnet test Muxarr.Tests/Muxarr.Tests.csproj507 passed, 1 skipped, 0 faileddotnet publish Muxarr.Web/Muxarr.Web.csproj -c Release -o Muxarr.Web/publishMuxarr.Web/Dockerfile/config/dataThe skipped test is the existing manual ISO language data generator.
Maintainer Note
Note: this was an AI-assisted change, but the scope was intentionally kept narrow: container path behavior, legacy DB migration, docs, and one focused regression test.
The generated code was reviewed manually, adjusted to avoid destructive DB deletion, tested with the project's test suite, and smoke-tested in Docker with both fresh and existing database scenarios.