Skip to content

Prepare repository for MICCAI camera-ready release - #8

Merged
Kirscher merged 2 commits into
mainfrom
camera-ready-miccai-2026
May 8, 2026
Merged

Kirscher merged 2 commits into
mainfrom
camera-ready-miccai-2026

Conversation

@Kirscher

@Kirscher Kirscher commented May 8, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 8, 2026 08:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a6e3e9cd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .gitignore Outdated
workdir_curvas/

# Medical imaging data, model outputs, and experiment artifacts
data/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Anchor data artifact ignore to repo root

Because this ignore pattern is unanchored, Git treats data/ as any directory named data under the repo, so new files beneath the existing src/data/ package are ignored as well (e.g. git check-ignore -v src/data/new_dataset/prepare.py reports this line). That makes future dataset preparation code or docs easy to miss from commits; use a rooted pattern like /data/ if only the repository-level artifact directory should be excluded.

Useful? React with 👍 / 👎.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the repository for a MICCAI 2026 camera-ready companion release by removing the previously referenced values submodule integration, tightening CI behavior, and updating documentation/dependencies to better reflect expected local artifact handling and dataset prep.

Changes:

  • Removed the values submodule wiring and its Python bridge module.
  • Updated documentation for installation, dataset preparation, and clarified that data/model artifacts are local-only.
  • Updated dependency requirements and made CI tests run strictly (no placeholder-pass behavior).

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/ensemble_metrics/values_bridge.py Removed the bridge module that attempted to import metrics from the former values submodule.
src/data/README.md Documented nnU-Net environment variables and clarified dataset placement/preprocessing instructions.
requirements.txt Adjusted NumPy requirement and added missing image I/O dependencies (Pillow, opencv-python-headless).
README.md Expanded project description, added install/test instructions, and documented local artifact expectations.
.gitmodules Removed the values submodule configuration.
.gitignore Added ignores for medical imaging datasets, nnU-Net folders, checkpoints, and common artifact file types.
.github/workflows/tests.yml Added the camera-ready branch trigger and made test execution strict (pytest -q).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines 46 to 50
If you use this work, please cite:

```
[Citation placeholder — add BibTeX or reference when published.]
TODO(author): Add BibTeX or proceedings reference when published.
```
@Kirscher
Kirscher merged commit b1e6ad2 into main May 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants