fix(build): source Skia natives from committed x64/ + hard-fail; v2.8.1 - #100
Merged
Merged
Conversation
The v2.8.0 release zip shipped without libSkiaSharp.dll. build.ps1 sourced the Windows native only from version-pinned NuGet-cache paths (skiasharp.nativeassets.win32/3.116.1 | 2.80.4) and, when those weren't present on the CI runner, skipped it with a soft Write-Warning. Result: a published zip whose Windows map renderer throws "Unable to load library 'libSkiaSharp'" — even though the .dll is committed in the repo. - build.ps1: source both Skia natives from the committed src/<mod>/x64/ copies first (same as sqlite3.dll), NuGet cache as dev fallback, and throw (hard build failure) if a native is missing so this can't silently recur. - ModInfo.xml: 2.7.4 -> 2.8.1 (was stuck, so the mod self-reported the wrong version vs the release tag). - CHANGELOG: [2.8.1] section covering VIP tiers, join diagnostics, PackRelay Launcher v0.1, and this packaging fix. Supersedes v2.8.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts v2.8.1 to fix a broken v2.8.0 release artifact.
What was broken
The published
KitsuneCommand-v2.8.0.zipwas missinglibSkiaSharp.dll(the Windows SkiaSharp native), so a clean Windows install'sMapTileRendererthrowsUnable to load library 'libSkiaSharp'. Root cause: build.ps1 sourced the Windows native only from version-pinned NuGet-cache paths (skiasharp.nativeassets.win32/3.116.1|2.80.4) and skipped it with a softWrite-Warningwhen those weren't on the runner — even though the.dllis committed atsrc/KitsuneCommand/x64/libSkiaSharp.dll.ModInfo.xmlwas also stuck at2.7.4, so the mod self-reported the wrong version.Fix
src/.../x64/copies first (exactly likesqlite3.dll), NuGet cache kept as a dev fallback, and a missing native is a hardthrowso a future drop fails the build loudly instead of shipping broken.2.7.4→2.8.1.[2.8.1]section (VIP tiers, join diagnostics, PackRelay Launcher v0.1, this packaging fix).Verify after merge
Tag
v2.8.1, then confirm the produced zip'sx64/containslibSkiaSharp.dllandModInfo.xmlsays2.8.1before publishing. The brokenv2.8.0release gets deleted.🤖 Generated with Claude Code