fix(build): unblock v2.8.0 — commit Skia natives + fix PlayerEditDialog test types - #99
Merged
Merged
Conversation
…og test types The v2.8.0 tag build failed two ways: - x64/libSkiaSharp.dll and .so are gitignored (only sqlite3.dll was force-added), but #96 added <None Include="x64\libSkiaSharp.*"> to the csproj. CI checks out without them -> MSB3030 "could not copy ... not found". Force-add both (like sqlite3.dll) so the release zip bundles the natives the mod loads from x64/. - PlayerEditDialog.test.ts: the `player` mock had 5 of PlayerInfo's 20 fields, and mockGetMetadata was inferred to return `undefined` so it rejected the seeded {playerId, vipTier}. Completed the PlayerInfo mock, typed the metadata mock as PlayerMetadata | undefined, and completed the seeded object. `vue-tsc --noEmit` now passes locally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v2.8.0tag build failed (run 26652746736) for two reasons — both fixed here,vue-tsc --noEmitverified green locally:① Skia natives missing on CI (MSB3030)
x64/libSkiaSharp.dlland.soare gitignored (x64/rule); onlysqlite3.dllwas ever force-added. PR #96 added<None Include="x64\libSkiaSharp.*">to the csproj, so CI — checking out without those files — failed with "could not copy … not found." The mod loads them at runtime from<modPath>/x64/, so the release zip must bundle them. Force-added both (same pattern assqlite3.dll).② PlayerEditDialog.test.ts type errors
playermock had 5 ofPlayerInfo's 20 fields → completed it.mockGetMetadatainferred aundefinedreturn, so it rejected the seeded{playerId, vipTier}(also an incompletePlayerMetadata) → typed itPlayerMetadata | undefinedand completed the object.Next
Once merged: delete the failed
v2.8.0tag and re-push it at the newmainso the Release workflow rebuilds the draft.🤖 Generated with Claude Code