Repository navigation
Test CI with turbo-jpeg, benchmarks, and image orientation tests - #66
Merged
Thibault-Pelletier merged 2 commits intoOct 9, 2026
Merged
Thibault-Pelletier merged 2 commits into
Thibault-Pelletier merged 2 commits into
Conversation
user27182
marked this pull request as ready for review
October 7, 2026 21:29
user27182
force-pushed
the
ci/turbo-benchmarks-orientation
branch
from
October 7, 2026 22:21
42c4d01 to
ad37d31
Compare
user27182
force-pushed
the
ci/turbo-benchmarks-orientation
branch
from
October 7, 2026 22:33
ad37d31 to
fe54a08
Compare
Contributor
|
Thx @user27182 for working on this. Could you just update your commits so that:
|
img_cols_rows unpacked vtkImageData.GetDimensions(), which is (width, height, depth), as rows, cols, so it returned the height as cols and the width as rows, unlike the protocol and the vanilla example. The array shape was right, but the encoders' meta reported w and h swapped for non-square windows. Add a test with a non-square window that checks cols, rows and every encoder's meta w/h.
- CI: install libjpeg-turbo 3.2.0 (checksum pinned) on Linux and Homebrew's jpeg-turbo on macOS. Ubuntu's libturbojpeg 2.1.5 lacks the tj3* API PyTurboJPEG 2 needs, so turbo-jpeg silently fell back to Pillow; the job now fails if it does. README's Ubuntu instructions point to the official package too. - CI: select OSMesa directly on Linux (VTK_DEFAULT_OPENGL_WINDOW), so render windows no longer log "Failed to load EGL!" first. - Benchmark VtkRemoteControlledArea.img_cols_rows on a 1920x1080 frame separately from encoding it with each encoder (pytest-benchmark, dev extra); CI saves the results as a Linux artifact. - Check each quadrant's color in the img_cols_rows array and in every encoder's decoded output, that encoded frames have no alpha channel, and that a frame isn't overwritten by the next capture. - Check that every encoder gives the same bytes for non-contiguous RGB arrays (views of RGBA, bottom-up, mirrored, transposed, strided, Fortran order) as for a contiguous copy; these need no rendering and also run on macOS and Windows CI.
user27182
force-pushed
the
ci/turbo-benchmarks-orientation
branch
from
October 8, 2026 16:53
fe54a08 to
ae12d33
Compare
Contributor
Author
|
The commits have been restructured |
Collaborator
|
@Thibault-Pelletier I let you merge it once you are ok with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI fixes, benchmarking, and new tests, so that #65 can land with improved confidence nothing breaks.