Skip to content

electron shared texture - #69

Open
jspanchu wants to merge 11 commits into
masterfrom
electron-shared-texture
Open

jspanchu wants to merge 11 commits into
masterfrom
electron-shared-texture

Conversation

@jspanchu

Copy link
Copy Markdown
Member
  • chore(deps): bump minimum python version to 3.10
  • feat(electron-shared-texture): Add new electron shared texture display area
  • fix(electron): add profiler for render and flush
  • fix(example): enable profiler in electron example
  • fix(windows): set timer resolution to 1ms

- needed to satisfy the trame >= 4 in dev.
@jspanchu
jspanchu requested a review from jourdain October 19, 2026 23:08
Comment thread .github/workflows/test_and_release.yml Outdated
Comment thread electron/src/main/dma/iosurface.js Outdated
Comment thread electron/src/main/dma/iosurface.js Outdated
_initialized = False


def emp_port(server):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that support multi-views?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of args.emp_port should we have a --trame-electron with some json data instead so we can expand as needed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will add an extra json step and documentation will be weird. with args, i can describe the meaning of the arg properly.

Comment thread pyproject.toml
"vtk",
"vtk-streaming>=0.4.0",
]
electron = [

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seems worth adding the electron option here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, vtk is never pulled by uv sync or pip install -e. Without it, to get vtk, you have to do pip install -e.[vtkstreaming] even if you want to use electron which is weird.

Comment thread README.rst
@jourdain

Copy link
Copy Markdown
Collaborator

I'll need to read stuff in more details, but that was a quick look around.

@Thibault-Pelletier

Copy link
Copy Markdown
Contributor

Packaging question: should this be in its own trame-electron repo instead of in the trame-rca one?
I feel like it would be easier for people to find and extend it.

Disclaimer: Haven't looked at the code yet, so not sure how much it's coupled with the current impl / how it would be decoupled or reusable on its own

@jspanchu

Copy link
Copy Markdown
Member Author

a trame-electron package is yet to be created and it will have the application scaffolding code that make it convenient to write apps. this code is the sharedTexture stuff which is coupled to the python rca scheduler.

@jspanchu
jspanchu force-pushed the electron-shared-texture branch from aec1a98 to ba4b112 Compare October 20, 2026 12:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants