Skip to content

refactor(framebuffer)!: remove deprecated getColorTexture method - #3694

Open
PaulHax wants to merge 2 commits into
typescript-types-syncfrom
remove-framebuffer-color-texture
Open

PaulHax wants to merge 2 commits into
typescript-types-syncfrom
remove-framebuffer-color-texture

Conversation

@PaulHax

@PaulHax PaulHax commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Context

getColorTexture() is a deprecated accessor for the first color attachment.

Results

Use getColorBuffers()[0].

Changes

Remove the method and declaration. Update four rendering callers to getColorBuffersByReference()[0] to avoid copying the array. Extend the attachment-slot test and add the migration note.

PR Checklist

  • GitHub Actions CI passed: semantic-release commit messages, lint, and tests
  • Test coverage added
  • Documentation and TypeScript definitions are updated to match these changes

@daker daker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHax
PaulHax force-pushed the remove-framebuffer-color-texture branch from 8dd166f to f740018 Compare October 19, 2026 20:43
@PaulHax
PaulHax added this pull request to stack #3695 October 19, 2026 20:46
@PaulHax
PaulHax removed this pull request from stack #3695 October 19, 2026 21:01
@PaulHax
PaulHax added this pull request to stack #3696 October 19, 2026 21:01
@PaulHax
PaulHax force-pushed the remove-framebuffer-color-texture branch from f740018 to 8faf1cd Compare October 22, 2026 16:12
@PaulHax
PaulHax force-pushed the remove-framebuffer-color-texture branch from 8faf1cd to d63f2b1 Compare October 22, 2026 16:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants