feat: add lint rule for shiv plugin prerequisites#60
Open
olavostauros wants to merge 3 commits into
Open
Conversation
Adds mise-shiv-plugin lint rule that flags mise.toml files declaring shiv-managed tools without the required [plugins] shiv entry and [settings] experimental = true. Based on the CI failure observed in KnickKnackLabs/chat#39. Includes 11 BATS tests across 7 fixture scenarios, plus an ignore directive on an existing github-actions fixture that declares shiv tools. Implements KnickKnackLabs#34 (KnickKnackLabs/codebase)
This was referenced Jun 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
mise-shiv-pluginlint rule that ensures repos declaring shiv-managed tools inmise.tomlhave the required plugin setup. Without this,mise installfails silently on clean CI runners with"shiv is not a valid plugin name"and"custom backends is experimental"— as observed in KnickKnackLabs/chat#39.The rule:
[tools]for keys matchingshiv:*[plugins] shiv = "https://github.com/KnickKnackLabs/vfox-shiv"and[settings] experimental = trueFAIL, clean or no-shiv-tools asOK, file-level ignores asSKIP, missingmise.tomlasINFOAffects 6/8 KKL repos that declare shiv tools (chat, modules, notes, readme, shimmer, shiv).
Files changed
.mise/tasks/lint/mise-shiv-plugintest/lint/mise-shiv-plugin/mise-shiv-plugin.batstest/lint/mise-shiv-plugin/fixtures/test/lint/github-actions/fixtures/fix-lints-provisioned/mise.tomlcodebase:ignore mise-shiv-pluginto prevent cross-rule flaggingValidation
mise run test— 229/229 pass (11 new tests at indices 116–126, zero regressions)mise run lint:mise-shiv-plugin .— self-hosting clean (codebase repo has no shiv tools)mise run lint:shellcheck .mise/tasks/lint/mise-shiv-plugin— ShellCheck-cleangit diff --check— no whitespace errorsCloses #34