Skip to content

Support Zed review task and snippet fields#2

Merged
ikma-ricon merged 1 commit into
mainfrom
ikma/ctl-1-zed-review-fields
Jul 18, 2026
Merged

Support Zed review task and snippet fields#2
ikma-ricon merged 1 commit into
mainfrom
ikma/ctl-1-zed-review-fields

Conversation

@ikma-ricon

Copy link
Copy Markdown
Contributor

Summary

  • add optional Zed task reveal, shell, shell-argument, and environment fields
  • add checked editor::InsertSnippet keymap bindings with conflict and force behavior
  • preserve the existing minimal task shape when new fields are omitted
  • validate policy enums and environment entries before writing
  • document the concrete inline-review workflow

Design choices

  • a shell program without arguments uses Zed's simple { "program": ... } form
  • shell arguments use shell.with_arguments
  • same-label task upsert continues replacing the whole task, including its environment
  • snippet support remains limited to the proven inline editor::InsertSnippet action

Validation

  • mise run test (34 tests)
  • mise run doctor
  • codebase lint (9 rules)
  • readme build --check
  • Bash syntax checks for changed tasks
  • git diff --check

Closes #1

@ikma-ricon
ikma-ricon merged commit c7f6f47 into main Jul 18, 2026
2 checks passed
@ikma-ricon
ikma-ricon deleted the ikma/ctl-1-zed-review-fields branch July 18, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Zed task and snippet fields proven by inline review

1 participant