fix: reject unreadable manifest path shapes#178
Open
johnson-ricon wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
The changed-note reducer treats only exact readable-path equality as a manifest collision. A manifest can also map one blob to
sharedand another toshared/child.md. A full readable-tree materialization cannot represent that ref and fails regardless of row order, but the reduced path can select only the changed child ID, omit the colliding parent ID, and emit a plausible patch.This fix validates the complete existing-blob mapping for each ref and rejects any readable path that is also another mapped path's directory. Exact duplicate paths remain supported for the alias semantics repaired by #177.
Validation
mise run test— 405 BATS tests and 9 Python tests passedmise run test diff— 15/15 passedmise run doctorpassed; optional local pre-commit hook remains uninstalledbash -n lib/diff.sh .mise/tasks/diffreadme build --checkgit diff --checkFixes one adversarial review finding on #176.