fix: preserve manifest collision order#179
Open
johnson-ricon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
PR #177 repairs exact-row aliases and expands exact ID/path components, but exact row sets discard manifest order. When two IDs map to one readable path, full materialization uses the last row as the resulting file. Reordering those same rows can therefore change readable content without changing any row membership or blob. Exact head
3de63a2selects no IDs and reports no readable change.This fix records each ref's ordered ID sequence per readable path. A changed sequence seeds every ID on that path before the existing component expansion, preserving full-tree overwrite semantics while retaining changed-only blob materialization.
Validation
mise run test— 405 BATS tests and 9 Python tests passedmise run test diff— 15/15 passedmise run doctorpassed; optional local pre-commit hook remains uninstalledbash -n lib/diff.sh .mise/tasks/diffreadme build --checkgit diff --checkFixes one adversarial review finding on #176.