Skip to content

fix: keep trailing-slash deobfuscation scoped #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junior-ricon merged 1 commit into from
Jul 28, 2026
Merged

fix: keep trailing-slash deobfuscation scoped #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .mise/tasks/deobfuscate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ if [ -n "${usage_files:-}" ]; then
arg="${arg#"${notes_dir}/"}"
# Skip empty variadic defaults after xargs unquotes "''".
[ -z "$arg" ] && continue
# Match basename's handling of trailing slashes without spawning it.
while [ -n "$arg" ] && [ "${arg%/}" != "$arg" ]; do
arg="${arg%/}"
done
arg="${arg##*/}"
ARGS+=("$arg")
done < <(printf '%s' "${usage_files}" | xargs printf '%s\n')
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

**Collective memory, encrypted.**

[![tests: 422](https://img.shields.io/badge/tests-422-brightgreen?style=flat)](test/)
[![tests: 423](https://img.shields.io/badge/tests-423-brightgreen?style=flat)](test/)
![lints: 8](https://img.shields.io/badge/lints-8-blue?style=flat)
[![license: MIT](https://img.shields.io/badge/license-MIT-blue?style=flat)](LICENSE)

Expand Down
15 changes: 15 additions & 0 deletions test/deobfuscate.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,21 @@ BASH
}


@test "scoped deobfuscate keeps a trailing-slash path scoped" {
notes obfuscate

local alpha_id beta_id
alpha_id=$(grep 'alpha.md' "$NOTES_CALLER_PWD/notes/.manifest" | cut -f1)
beta_id=$(grep 'beta.md' "$NOTES_CALLER_PWD/notes/.manifest" | cut -f1)

notes deobfuscate "notes/$alpha_id/"

[ -f "$NOTES_CALLER_PWD/notes/alpha.md" ]
[ -f "$NOTES_CALLER_PWD/notes/$beta_id" ]
[ ! -f "$NOTES_CALLER_PWD/notes/beta.md" ]
}


@test "deobfuscate with args warns on unknown ID" {
notes obfuscate

Expand Down
Loading