fix: verify the active Notes hook chain - #192
Merged
junior-ricon merged 1 commit intoJul 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
PR #191's new required-hook check can approve a hook chain that Git will not execute.
Two disposable reproductions committed
notes/alpha.mdas a readable path afternotes stagesucceeded:core.hooksPathpointed at.githooks, while Notes installed and inspected inactive.git/hooks;pre-commitonly mentionedpre-commit.din a comment and exited zero without running any fragments.Both cases bypass the fail-closed staging invariant from #152.
Fix
git rev-parse --git-path hooks;notes install-hooks --yes;Validation
mise run test stage(27 tests)mise run test obfuscation-hooks(24 tests)mise run test encrypt(25 tests)mise run test commit(13 tests)mise run test integration(32 tests, 3 environment skips)mise run doctorreadme build --checkbash -n lib/hooks.shgit diff --checkA complete local suite attempt reached test 173/451 without an assertion failure before the 600-second harness limit; exact PR #191 hosted macOS and Ubuntu checks were green before this branch was created.