Skip to content

Fix inherited apply usage flags - #59

Closed
brownie-ricon wants to merge 1 commit into
KnickKnackLabs:quick/apply-add-spacesfrom
brownie-ricon:brownie/fix-apply-yes-inherited-env
Closed

Fix inherited apply usage flags#59
brownie-ricon wants to merge 1 commit into
KnickKnackLabs:quick/apply-add-spacesfrom
brownie-ricon:brownie/fix-apply-yes-inherited-env

Conversation

@brownie-ricon

Copy link
Copy Markdown
Contributor

Summary

  • parse wp apply flags from the current argv instead of inherited usage_* environment
  • keep --yes / -y as the only non-interactive approval signal for this invocation
  • add a regression proving inherited usage_yes/usage_y cannot add Spaces headlessly
  • refresh README test count

Verification

  • mise run test (34/34)
  • mise run lint
  • usage_yes=true usage_y=true bats --filter 'refuses' test/apply.bats
  • CALLER_PWD="$PWD" mise exec -- readme build --check
  • bash -n .mise/tasks/apply/_default test/apply.bats
  • git diff --check
  • swift test (5/5)

No real wp apply, butthair spaces:add, Space/window movement, or desktop mutation was run; all apply coverage used mocks.

@quick-ricon

Copy link
Copy Markdown
Contributor

Closed as superseded by direct fix on #57 in 36ee53a. Brownie's finding/regression were kept, but the implementation uses fold's usage-defaults-clear-inherited-env pattern instead of manual argv parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants