C32 parser fix + internal dependabot updates 08-11-2026 - #54
Merged
Merged
Conversation
data.vitals read self.vitals but the property is self.vitalsParser, throwing TypeError for every C32 document. Also restore documentParser, which the DocumentParser assignment was clobbering demographicsParser with, matching the CCDA parser's naming. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes the C32 top-level parser wiring so it no longer crashes when parsing vitals and so the document section is parsed by the intended DocumentParser, and includes a lockfile-only transitive security update.
Changes:
- Restore
documentParseron the C32 parser and routedata.documentthrough it (instead of clobberingdemographicsParser). - Fix C32 vitals parsing by calling
self.vitalsParser.parse(...)(matching the instantiated parser). - Update
fast-urifrom3.1.4→3.1.5inpackage-lock.json.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package-lock.json | Bumps fast-uri to 3.1.5 (lockfile-only). |
| lib/parsers/c32.js | Fixes parser member assignments and corrects document/vitals parsing calls. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vamaral-kno2
approved these changes
Aug 11, 2026
dapperdandev
added a commit
to Kno2/ccdaview
that referenced
this pull request
Aug 12, 2026
…ates (#139) * PAC-40355: Update @kno2/bluebutton to 0.7.0 Picks up the C32 parser fix (Kno2/bluebutton.js#54) so C32 documents no longer crash the intake CDA preview. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: internal dependabot updates 08-11-2026 --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
data.vitalsreadself.vitalsbut the property isself.vitalsParser, throwingTypeError: Cannot read properties of undefined (reading 'parse')for every C32 document (broken since the 2017 webpack refactor). Also restoresdocumentParser, which theDocumentParserassignment was clobberingdemographicsParserwith, matching the CCDA parser's naming.Lockfile-only (transitive / security)
Excluded (major npm version — handle separately)
package-lock.json was reconciled with npm and verified stable: a fresh
npm installproduces no further changes.🤖 Generated with Claude Code