chore: remove dead Travis CI config - #61
Closed
dapperdandev wants to merge 1 commit into
Closed
dapperdandev wants to merge 1 commit into
dapperdandev wants to merge 1 commit into
Conversation
Addresses Copilot review comment 4031277375 on #60. .travis.yml pins node_js: 14 and reads as though it were a live CI path, but Travis posts no checks on this repo (PR checks are CodeQL and the Analyze jobs), nothing references the file, and it has not been touched since 2021-04-19. CI runs from .github/workflows, which already resolves node from .nvmrc. Removing it so the repo has one source of truth for the CI runtime. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The deletion is scoped and has no unresolved issues.
Pull request overview
Removes the obsolete Travis CI configuration, leaving GitHub Actions as the active CI path.
Changes:
- Deletes
.travis.yml. - Preserves the existing GitHub Actions workflow and
.nvmrcruntime selection.
File summaries
| File | Description |
|---|---|
.travis.yml |
Removes unused Travis CI configuration. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
Folded into #60. Commit 31781f5 cherry-picked there as 0edc1fa. I had split this out to keep #60 scoped to .nvmrc + .npmrc, but one PR per repo is the better call here: the Travis removal only came up because of #60's toolchain bump, so reviewing them apart just splits one piece of context across two PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
.travis.yml.Why
Raised by Copilot on #60 (comment 4031277375), where it flagged that the file pins
node_js: 14and so would not follow that PR's toolchain bump. I declined it there to keep #60 scoped to.nvmrc+.npmrc; this is the follow-up.The finding was half right. The file does pin node 14, but it is not a live CI path:
Analyze (actions),Analyze (javascript)andCodeQL.grep -rl travis, excludingnode_modules, returns nothing).So nothing was running on node 14, and there is no behaviour change here. The problem is that the file reads as though it were live, which is what prompted the review comment in the first place. Real CI lives in
.github/workflows/npm-publish.yml, which resolves node from.nvmrc.Removing it leaves one source of truth for the CI runtime.
Scope
Deletion only, no other changes. Independent of #60 and mergeable in either order.
🤖 Generated with Claude Code