fix(config): accept settingsPath keys in config --set

[vishnujayvel]

What & why

Fixes #256. Reported by @tizerluo.

wigolo config --set searchBackend=hybrid returned Unknown setting even though that exact command is the documented example:

wigolo config --set searchBackend=hybrid # headless single-setting update
— docs/configuration.md line 21

Root cause: applyHeadlessSet → findField() only matched FieldDef.key (env-var style, e.g. WIGOLO_SEARCH — the names text --plain prints). The docs' --set examples and the --plain --json output use FieldDef.settingsPath (e.g. searchBackend), which was never checked, so the documented --set form was rejected as unknown_key.

Changes

• findField in src/cli/tui/actions/headless-set.ts: exact match on FieldDef.key first, then exact match on FieldDef.settingsPath.
• Regression tests: settingsPath key searchBackend=hybrid → status: 'ok' and save; env-style WIGOLO_SEARCH still works.

No changes to secret handling, coercion, validation, or propagation.

Out of scope

The issue also mentions tlsTier / WIGOLO_TLS_TIER. That env var has no config.json / settingsPath key today, so accepting it via --set would be new config surface — left as a maintainer decision, not part of this PR.

Testing

• Repro-first: before the fix, applyHeadlessSet({ key: 'searchBackend', value: 'hybrid', ... }) returned status: 'unknown_key' (1 failed | 11 passed in the file).
• After the fix: npx vitest run tests/unit/cli/tui/actions/headless-set.test.ts → 12 passed.
• Full suite: npx vitest run → 8300 passed, 72 failed, 11 skipped, 7 todo (720 files: 702 passed | 15 failed | 3 skipped). Failures are pre-existing / environment (integration browser pool, SPA settle, ImportScreen TUI timing, repl e2e) — none in headless-set.
• npx tsc --noEmit (npm run lint) → clean, exit 0.

Checklist

• Conventional Commits (fix(config): ...)
• Focused change (no unrelated refactoring)
• Read CONTRIBUTING.md (issue already open; tests added; no new deps)

Summary by CodeRabbit

• Bug Fixes

  • Improved --set so settings can be selected using either environment-style keys or settings paths.
  • Ensures matching settings are correctly applied, saved, and reported when using either key format.

• Tests

  • Added coverage for setting the search backend through both supported key formats.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3155fb39-8237-4a52-b539-fb419957d93f

📥 Commits

Reviewing files that changed from the base of the PR and between b3ccf92 and 53f094f.

📒 Files selected for processing (2)

• src/cli/tui/actions/headless-set.ts
• tests/unit/cli/tui/actions/headless-set.test.ts

---

📝 Walkthrough

Walkthrough

The headless --set action now resolves settings by environment-style key or settingsPath. Tests verify successful searchBackend updates through both searchBackend and WIGOLO_SEARCH.

Changes

Headless setting resolution

Layer / File(s)	Summary
Settings-path lookup and validation src/cli/tui/actions/headless-set.ts, tests/unit/cli/tui/actions/headless-set.test.ts	findField falls back to settingsPath lookup. Documentation lists both identifiers. Tests verify staging, saving, and reporting for both key formats.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the fix for accepting settingsPath keys in config --set.
Linked Issues check	✅ Passed	The changes resolve issue #256 by accepting searchBackend while preserving environment-style keys and excluding unsupported tlsTier.
Out of Scope Changes check	✅ Passed	The changes are limited to settingsPath lookup, documentation, and regression tests related to issue #256.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[vishnujayvel]

Thanks for the careful review — particularly for confirming the tlsTier / WIGOLO_TLS_TIER
exclusion was deliberate rather than an oversight. That was the one judgement call in the change:
accepting it would have meant inventing a settingsPath that doesn't exist today, which is new
config surface rather than a fix for #256.

Nothing further from me; happy to adjust if you'd rather the exclusion be explicit in code instead
of implied by the absent settingsPath.

[vishnujayvel]

Thanks @Frankie-Xu for the detailed reviews and the independent verification runs on headless-set.test.ts — glad the key→settingsPath precedence and the deliberate tlsTier exclusion both read right.

[KnockOutEZ]

Hi @vishnujayvel — thank you for this PR, and I'm sorry it's been sitting here without a proper review.

I've been heads-down building some pretty big features and improvements for wigolo, and as a solo dev, shipping that while also reviewing and maintaining every issue and PR has been genuinely hard. This one isn't forgotten — it just hasn't had the attention it deserves yet.

I'd really appreciate your patience here. I'm going to work through the open PRs and issues properly over the next few weeks (sooner if I can free up), and I'll follow up right here.

In the meantime, the wigolo Discord is open if you'd like to follow what's being built, ask questions, or nudge me directly: https://discord.gg/BkUUgz2bNF

Thanks again for contributing, and for understanding — it genuinely means a lot. 🙏