Conversation
- 背景 / Background:README 把不存在的 GHCR `:full` 写成预装浏览器镜像;真实发布标签为 `:latest-full` 和版本化 `-full`。 / README advertised the nonexistent GHCR `:full` tag; published tags use `:latest-full` or versioned `-full`. - 改动 / Changes:更新 README 与安装文档,明确区分 published image tag 和本地 Docker `full` build target;增加文档回归测试。 / Document the published tags separately from the local Docker `full` target and add regression coverage. - 文件 / Files:README.md,docs/installation.md,tests/unit/documentation/docker-image-tags.test.ts - 验证 / Verification:定向测试 2 passed;`npm run lint`、`npm run build` 通过;完整 `npm run test` 为 28 failed / 8,344 passed,失败均在未改动的 REPL/browser/health/init/perf/live research 测试。 / Focused tests passed; lint and build passed; full suite reported 28 unrelated failures and 8,344 passes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDocker documentation now describes published ChangesDocker image tag documentation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/unit/documentation/docker-image-tags.test.ts`:
- Around line 15-18: Update the test case around readme to assert that the
published ghcr.io/knockoutez/wigolo:full registry identifier is absent from both
the README content and docs/installation.md. Keep the local wigolo:full build
target valid and avoid relying only on the prose fragment about preinstalling
the browser engine.
- Line 5: Update the directory resolution used by the test around repoRoot to
avoid relying on import.meta.dirname across all advertised Node.js 20 versions;
derive the path from import.meta.url instead, unless you explicitly raise the
documented and package engine minimum to Node.js 20.11+ consistently.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: fabd6851-c7d1-48de-b6fe-512384956f06
📒 Files selected for processing (3)
README.mddocs/installation.mdtests/unit/documentation/docker-image-tags.test.ts
- 背景 / Background:PR review 指出测试依赖 Node 20.11+ 的 import.meta.dirname,且负向断言只绑定特定 README 句子。 / Review found a Node 20 compatibility gap and an overly narrow negative assertion. - 改动 / Changes:改用 fileURLToPath(import.meta.url) 定位仓库根目录,并在 README 与安装文档中直接排除远端 ghcr.io/knockoutez/wigolo:full。 / Resolve paths from import.meta.url and reject the nonexistent registry identifier in both documents. - 文件 / Files:tests/unit/documentation/docker-image-tags.test.ts - 验证 / Verification:定向测试 2 passed;npm run lint 与 git diff --check 通过。 / Focused tests, lint, and diff check passed.
|
Hi @w-up — thank you for this PR, and I'm sorry it's been sitting here without a proper review. I've been heads-down building some pretty big features and improvements for wigolo, and as a solo dev, shipping that while also reviewing and maintaining every issue and PR has been genuinely hard. This one isn't forgotten — it just hasn't had the attention it deserves yet. I'd really appreciate your patience here. I'm going to work through the open PRs and issues properly over the next few weeks (sooner if I can free up), and I'll follow up right here. In the meantime, the wigolo Discord is open if you'd like to follow what's being built, ask questions, or nudge me directly: https://discord.gg/BkUUgz2bNF Thanks again for contributing, and for understanding — it genuinely means a lot. 🙏 |
Summary / 摘要
Fixes #255.
The README described the browser-preloaded Docker image as
:full, but GHCR does not publish that tag. The release workflow publisheslatest-fulland versioned-fulltags such as0.2.1-full.README 把预装浏览器的 Docker 镜像写成了不存在的
:full。实际发布标签是latest-full,以及0.2.1-full这类版本化-full标签。Changes / 改动
Replace the nonexistent published
:fullreference withghcr.io/knockoutez/wigolo:latest-full.Document the versioned
-fullnaming convention.Add a runnable published-image example to the installation guide.
Keep the local build command
docker build --target full -t wigolo:full .and explicitly distinguish it from registry tags.Add a regression test that checks both public docs advertise
latest-fulland the stale README wording does not return.将不存在的远端
:full改为ghcr.io/knockoutez/wigolo:latest-full。说明版本化镜像统一使用
-full后缀。在安装文档中增加可直接运行的 published image 示例。
保留本地
docker build --target full -t wigolo:full .,并明确它是 local build tag,不是 GHCR tag。增加文档回归测试,防止旧写法再次出现。
Evidence / 证据
The GHCR Registry API currently reports:
The repository workflow also generates full-image tags with
suffix=-fullin.github/workflows/docker-publish.yml.Verification / 验证
The full suite was also run with the inherited
NODE_ENV=productionremoved:None of the failures touched the new documentation test or changed files. They were in existing REPL/readline, browser-pool timeout, health port collision (
19999is already used on this machine), init/TUI timeout, perf-threshold, and live research integration paths.Scope / 范围
CONTRIBUTING.mdand its CLA terms.Summary by CodeRabbit
Documentation
latest-fulland versioned-fulltags.Tests