Repository navigation
fix(ci): keep the running API image when the web triggers a deploy - #47
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #46: when a push to
maintriggers thereqsai-infraMVP deploy, passapi_ref=keepso only the web is rebuilt and the running API image is left untouched. Before, the API ref defaulted tomain, so the first web release would have redeployed the API from itsmain(still from July) and rolled it back.Feature module / area: ci
Related issue / US: continuous deployment of the MVP (reqsai-infra PR #7)
Type of Change
feat— new feature or UI componentfix— bug fixrefactor— code change without behavior changetest— tests onlydocs— documentation onlybuild/ci— build, dependencies, or CI/CDchore— maintenanceChecklist
develop(notmain)feature/*,bugfix/*, orhotfix/*bun run lintpasses locally (ESLint + angular-eslint)bun run testpasses locally (Vitest) — not applicable, workflow-only changebun run buildpasses locally (no type errors, no budget exceeded) — not applicable, workflow-only changeChangeDetectionStrategy.OnPushand Angular signals — not applicablelocalStorage/sessionStorageaccess for JWT tokens (use the auth store)bypassSecurityTrust*calls without explicit review.envcontent committedCHANGELOG.mdupdated under[Unreleased]— not needed for a one-line CI fixHow to Test
After the release to
main, the "Deploy" workflow run in this repo triggers "Deploy MVP" inKntro-Soft/reqsai-infrawithweb_ref=<sha>andapi_ref=keep; the API container is not recreated.