Repository navigation
fix(discovery): read the session stats and duration the API actually sends - #49
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In production, the session history (Captura › Historial) did not show the Historias / Aceptadas / Pendientes / Preguntas columns. Every live session showed "—" as its duration. The session separator in Captura never showed "N historias".
Root cause
DiscoverySessionResponsein the web expectedstoriesGeneratedCount,storiesAcceptedCount,pendingSuggestionsCountandquestionsCount. The API sendsstoriesGenerated,storiesAccepted,suggestionsPendingandquestionsAsked, soshowStats()was always false.audioDurationMs. Only uploaded recordings set that field; live sessions never do.Fix
durationSeconds.durationSecondsand falls back toaudioDurationMsfor older deployments.sessionDurationandhasSessionStats(history.helpers.ts).storiesGenerated.Companion API PR: Kntro-Soft/reqsai-api#99. It makes
durationSecondsreport the audio length of uploads and makesstoriesAcceptedcount accepted suggestions. Without it, this PR still shows the stats columns and live durations.Tests
ng test --watch=false: 40 files, 399 tests passed. That includes the newhistory.helpers.spec.ts(6 tests), also run alone.ng lint: clean.ng build: OK.