Skip to content

[WIP] Shugeo array refactor2#498

Open
shugeo wants to merge 101 commits intomasterfrom
shugeo_array_refactor2
Open

[WIP] Shugeo array refactor2#498
shugeo wants to merge 101 commits intomasterfrom
shugeo_array_refactor2

Conversation

@shugeo
Copy link
Copy Markdown

@shugeo shugeo commented Jun 25, 2020

What changes were proposed in this pull request?

Refactored NDArrayFactory to use proper create methods

How was this patch tested?

All appropriate tests already added

Quick checklist

The following checklist helps ensure your PR is complete:

  • Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
  • Reviewed the Contributing Guidelines and followed the steps within.
  • Created tests for any significant new code additions.
  • Relevant tests for your changes are passing.

shugeo added 30 commits June 2, 2020 10:44
@shugeo
NDArrayFactory: eliminated methods to return array pointers.
8f5fa52 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected tests to eliminated factory empties and creations.
af04763 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Refactored valueOf methods and tests.
b886e8f 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed usage of legacy create_ factory method.
c3472a9 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Refactored benchmarking without legacy create_ method.
a38c361 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Refactored tests to eliminated usage of legacy create_ factory method.
48b442c 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected tests to eliminate legacy factory methods usage.
dcdf56c 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Eliminated legacy factory method usage with ops tests.
4698bd3 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Eliminated factory method create_ with tests.
a58bac2 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Eliminated legacy create_ factory method usage.
62275ec 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Eliminated legacy usage for factory method create_
7c1312d 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Eliminated legacy method for create_ with tests.
63a4235 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Cosmetic changes only.
a74c999 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed valueOf factory routine definition and usage.
3ee5b9b 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed NDArrayFactory class and so on.
ea5c586 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed implementations.
b67d85c 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed list ops.
f2ee085 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed gather_list and write_list ops.
2b9bd32 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed nn ops.
a491b70 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed misc typo errors.
628a98c 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Refactored context to use reference as input/output arrays.
bb88dda 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed benchmarking with refactored context.
b2d5d1c 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed cuda implementation due refactored legacy factory methods creat…
dede047 
…e_ and empty_

Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Refactored benchmarks with new elementar base.
b5fca36 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Adopted tests to non-pointer arrays.
d8cfcdb 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed issues with the first test file.
edbbf62 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected context usage with test.
1d6ea1b 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Added Order enum for NDArray orders.
30d3e62 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Refactored factory to eliminated expensive methods.
5a4fd0b 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Refactored enum
20f83f2 
Signed-off-by: shugeo <sgazeos@gmail.com>
shugeo added 20 commits June 23, 2020 18:01
@shugeo
Fixed cuda tests to adopt refactored array factory methods.
440324e 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed link errors with typo with new array factory create methods.
1fb5b49 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected tests to proper use new create array factory methods.
276e092 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected tests with refactored array constructors and variables.
30b4929 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected image resize tests to adopt proper size vector creation.
b1baa46 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed array factory methods usage with image tests and so on.
033e0d9 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed array factory constructor usage with tests.
aa8c683 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed the tenth test file with misc array factory constructions.
f3f81c1 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected array factory creators usage with ninth test file.
6727613 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected array factory creators usage with eighth and seventh test f…
96b1a3f 
…iles.

Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected the sixth test file with refactored array creators.
4c48977 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected the fifth test file to adopt array factory create methods.
175babc 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected the fourth test file to adopt array factory create methods.
6431990 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected the third test file to adopt array factory create methods.
58ecc5a 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected the second test file to adopt array factory create methods.
166724c 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected the first test file to adopt array factory create methods.
eb04bbd 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected tests to adopt refactored creators with array factory.
96ff7b5 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected tests to adopt new array factory creators.
e3a9a07 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Corrected rest tests to adopt new array factory create methods.
6995262 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed cuda typo with new array factory methods.
bb1a9f9 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo shugeo changed the title [WIP] Shugeo array refactor2 Shugeo array refactor2 Jun 26, 2020
@shugeo shugeo changed the title Shugeo array refactor2 [WIP] Shugeo array refactor2 Jun 26, 2020
shugeo added 8 commits June 26, 2020 20:10
@shugeo
Merged with master and adopt master changes with local changes.
9aace98 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed misc with merging.
e82e5af 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed tests.
31f9198 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed RNG tests.
7147dcc 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Merge branch 'master' into shugeo_array_refactor2
9509555
@shugeo
Fixed memory leaks with tests and sru_bp op.
8e69828 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed memory leak with bool creation.
d22bca2 
Signed-off-by: shugeo <sgazeos@gmail.com>
@shugeo
Fixed memory leak for bool array creation.
51b56a3 
Signed-off-by: shugeo <sgazeos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shugeo