feat(ci): skip running the job when condition not met#353
Open
feat(ci): skip running the job when condition not met#353
Conversation
ValeryG
previously approved these changes
Dec 18, 2025
Collaborator
ValeryG
left a comment
ValeryG
left a comment
There was a problem hiding this comment.
the reason why didn't do from the start is I want to see more information (console.logs) as of why coverage is skipped) :) but I that's the fine change :)
* Restore the former way of the CI process but put the condition determinations prior to fetching data from GitHub API.
jw-foss
force-pushed
the
feat/bail-early-when-seeking-mgr-approvals
branch
from
55da011 to
5bea11c
Compare
Contributor
Author
|
@ValeryG I pushed new code, restored the old way but put the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For now job
Check for test coverage, gets to run every time, which fetches and calculates data even if the conditions were not met for instance in our case:srcrelated files gets changedtestgets changedSince we do not want these to run under these scenario, I think we should bail early to avoid make requests and calculations ahead of the time.