NFT tweaks#409
Merged
Merged
Conversation
…iews - mint: replace `description: string` with `attributes: list<attribute>` (≤32 entries, unique non-empty keys ≤64B, values ≤2048B), set once at mint - nft-info: add immutable `creator` (= mint signer), drop `description` - views: add `list-nfts`, `list-nfts-by-creator`, `count-nfts-by-creator` (offset/limit, internal cap), plus `get-attributes` / `get-attribute` - backed by a creator→nft-ids index populated at mint
adamkrellenstein
approved these changes
May 11, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9337705. Configure here.
wilfreddenton
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replace description with attribute map and add creator/listing views
description: stringwithattributes: list<attribute>(≤32 entries, unique non-empty keys ≤64B, values ≤2048B), set once at mintcreator(= mint signer), dropdescriptionlist-nfts,list-nfts-by-creator,count-nfts-by-creator(offset/limit, internal cap), plusget-attributes/get-attributeNote
Medium Risk
Medium risk because it changes the NFT contract storage and WIT interface (breaking
mint/nft-infoshape) and introduces new indexing/pagination logic that could affect on-chain data compatibility and query correctness.Overview
NFT contract API/storage refactor: replaces
descriptionwith an immutableattributesmap set atmint, adds a permanentcreatorfield (mint signer), and updates validation to enforce attribute count/size/uniqueness constraints.New read APIs: adds paginated
list-nfts,list-nfts-by-creator, andcount-nfts-by-creator(with internallimitclamp and lenient handling of invalid creators), plusget-attributes/get-attributeviews.Indexing + tests: introduces a per-creator secondary index populated at mint (not affected by transfers) and significantly expands the native NFT contract integration test coverage for attributes, creator invariance, pagination, and edge cases;
Cargo.lockis updated for WIT/wasm tooling version resolution.Reviewed by Cursor Bugbot for commit 2bb67d8. Bugbot is set up for automated code reviews on this repo. Configure here.