indexer: sponsored aggregate RegisterBlsKey for new signers#412
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default mode and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3b43e8c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes the on-chain instruction/operation wire format and BLS aggregate verification/execution paths (including nonce handling and payer attribution), which could break compatibility and affect signature validation if any edge cases are missed.
Overview
Adds aggregate support for
RegisterBlsKey, including sponsored registration for new signers viaSignerClaim::PubKey, and moves replay protection into the aggregate envelope by requiring a per-op nonce inAggregateInfo.signers.Refactors the instruction/op wire format:
Inst/Opbecome{ payment, kind }and{ metadata, kind },Paymentis moved intoOpMetadata(with a core-paid sentinel forIssuance), and aggregate signing messages now cover(SignerClaim, nonce, inst)instead of(signer_id, inst).Updates aggregate verification to resolve
SignerClaimtosigner_id, verifyRegisterBlsKeycontributions against the inlinebls_pubkey(and ensuresigner_mapis populated), advances nonces for all aggregate ops using the envelope nonce, and chargesRegisterBlsKeyvia aregistry.registered()contract call before writing the key.Reviewed by Cursor Bugbot for commit edb8a15. Bugbot is set up for automated code reviews on this repo. Configure here.