indexer: surface op outcomes via simulate errors + OpStatus column#413
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default mode and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 38d8f31. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Adds a new DB column and API surface changes (
OpWithResultenum +OpStatus) that affect persisted data, TypeScript bindings, and transaction execution/simulation plumbing; mistakes could break result queries or client decoding.Overview
/transactions/simulatenow surfaces per-op deterministic failure details by collecting errors during execution and attaching them aserror_messageon each returnedOpWithResultentry (while/inspectcontinues to returnerror_message: None).The response shape is updated from a struct to a tagged
OpWithResultenum withMaterializedvsRejectedvariants, and ops now carry an explicitop_indexinOpMetadatafor stable positional alignment.Result persistence is extended with an
OpStatusenum:contract_resultsgains a non-nullstatuscolumn, the runtime classifies execution outcomes (Ok/ContractErr/OutOfFuel/Trap/Other), and queries/insert paths + TS bindings are updated accordingly; new tests cover simulate error surfacing and status classification.Reviewed by Cursor Bugbot for commit 7a84143. Bugbot is set up for automated code reviews on this repo. Configure here.