sdk: move kontor-sdk crate into core workspace tree#415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Build tooling and workspace wiring changes may break Rust/wasm component generation or Node SDK packaging if paths/working directories are incorrect, but no runtime logic changes are introduced.
Overview
Moves the
kontor-sdkRust crate into thecore/workspace tree by adding it as a workspace member and updating its local path dependencies.Updates the WASM/component build pipeline to run
jco transpilefromsdk/(so it uses the localnode_modules) and adjusts the Node packagebuild:rsscript to invoke the newcore/kontor-sdk/build.shlocation.Reviewed by Cursor Bugbot for commit c529c39. Bugbot is set up for automated code reviews on this repo. Configure here.