epic/B11: delete local NVMS implementation after repoint#247
epic/B11: delete local NVMS implementation after repoint#247KooshaPari wants to merge 5 commits into
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
CodeAnt AI is reviewing your PR. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI finished reviewing your PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b235e8ffe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| router.POST("/deploy", validateAction(projectManager.DeployProject)) | ||
| router.POST("/terminate", validateAction(projectManager.TerminateProject)) |
There was a problem hiding this comment.
Restore an NVMS deploy target before deleting the service
In the deploy/terminate flow I checked, backend/byteport/main.go still registers POST /deploy and /terminate, and backend/byteport/routes/deployment.go still forwards them to http://localhost:3000/deploy and /terminate. Deleting the only in-repo Spin router that served those endpoints means any request to those routes now fails with connection refused unless an unmanaged external nvms process happens to be running; the parser repoint described here does not replace this HTTP service.
Useful? React with 👍 / 👎.
| @@ -1,22 +0,0 @@ | |||
| module nvms | |||
There was a problem hiding this comment.
Remove the deleted nvms module from CI matrices
The active .github/workflows/ci.yaml matrix still lists backend/nvms for both vet and build and passes ${{ matrix.module }}/go.mod to setup-go before running in that working directory. With this go.mod and directory deleted, every PR/push run will include backend/nvms jobs that fail before vet/build; update the workflow matrix and related nvms CI/audit references together with the deletion.
Useful? React with 👍 / 👎.
|



User description
Summary
Delete BytePort's local NVMS implementation after repoint to phenotype-tooling/nanovms/parser (B10).
Context
Following B10 which re-pointed BytePort's NVMS parser from the local
backend/nvms/Go module to the sharedphenotype-tooling/nanovms/parser, this unit removes the now-redundant local implementation. The NVMS parser and all its supporting infrastructure (Go services, Rust parser, AWS spin library, provider sub-modules, examples, config files) are fully replaced by the external dependency.Changes
backend/nvms/— entire Go module (Demonstrator, Builder, Provisioner services, lib/awspin AWS abstraction, lib/providers, models, projectManager)backend/nvms.rs— Rust NVMS parser implementationbackend/odin.nvms— NVMS configuration fileTaskfile.yml— removedbackend/nvmsfrom gofmt, grep-hygiene, and commentsjustfile— removedbackend/nvmsfrom gofmt referencesFiles Deleted
70 files, ~7000 lines of code removed.
Testing
Links
CodeAnt-AI Description
Remove the local NVMS backend now that deployment uses the shared parser
What Changed
Impact
✅ Smaller codebase to maintain✅ Fewer stale references in project checks✅ Clearer repo status for contributors💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.