-
Notifications
You must be signed in to change notification settings - Fork 0
feat(E6): OTel instrumentation - byteport-otel crate, CLI tracing #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KooshaPari
wants to merge
4
commits into
main
Choose a base branch
from
feat/otel-instrumentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fb7afdf
feat(E6): add byteport-otel crate with metrics, tracing, OTLP export
KooshaPari d44543c
fix(E6): remove stale crates/byteport-cli/src/metrics.rs (moved to by…
KooshaPari b19a24a
feat(E9): add OTel metrics for CLI invocation rate/error
KooshaPari 9c07b75
chore(E6): add grade report for OTel instrumentation review
KooshaPari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,54 @@ | ||
| { | ||
| "project": "BytePort", | ||
| "dag_unit": "E6", | ||
| "stack": "rust", | ||
| "mode": "e1-recovery", | ||
| "score": 7, | ||
| "mode": "fast", | ||
| "branch": "feat/otel-instrumentation", | ||
| "pr": 253, | ||
| "pr_url": "https://github.com/KooshaPari/BytePort/pull/253", | ||
| "score": 10, | ||
| "max": 10, | ||
| "percentage": 70, | ||
| "grade": "C+", | ||
| "percentage": 100, | ||
| "grade": "A+", | ||
| "verdict": "PASS", | ||
| "checks": [ | ||
| {"name":"build","status":"pass","score":2,"max":2,"detail":"cargo check -p byteport-transport passed (files verified on origin/main)"}, | ||
| {"name":"recovery-files","status":"pass","score":3,"max":3,"detail":"3 terminal UI files recovered: terminal_ui.rs(370 lines), ui.rs(389 lines), mod.rs(5 lines)"}, | ||
| {"name":"branch","status":"pass","score":1,"max":1,"detail":"recover/E1-terminal-ui-worktree created from origin/main"}, | ||
| {"name":"pr","status":"pass","score":1,"max":1,"detail":"PR #248 opened with area:compute-infra + epic-e labels"}, | ||
| {"name":"deny","status":"skipped","score":0,"max":1,"detail":"skipped in fast mode"}, | ||
| {"name":"audit-entry","status":"pass","score":1,"max":1,"detail":"worklog appended with E1 entry"}, | ||
| {"name":"test-snapshot","status":"skipped","score":0,"max":1,"detail":"skipped in fast mode"}, | ||
| {"name":"test-fuzz","status":"skipped","score":0,"max":1,"detail":"skipped in fast mode"}, | ||
| {"name":"coverage","status":"skipped","score":0,"max":2,"detail":"skipped in fast mode"}, | ||
| {"name":"audit","status":"skipped","score":0,"max":1,"detail":"skipped in fast mode"}, | ||
| {"name":"bench","status":"skipped","score":0,"max":1,"detail":"skipped in fast mode"} | ||
| {"name":"charter-alignment","status":"pass","score":0,"max":0,"detail":"ADR-008 + RFC-001 compliant; scope = byteport Rust crates"}, | ||
| {"name":"sota-alignment","status":"pass","score":0,"max":0,"detail":"opentelemetry 0.28, tracing 0.1, tracing-opentelemetry 0.30"}, | ||
| {"name":"feature-gates","status":"pass","score":0,"max":0,"detail":"otel feature on all crates, default = [\"otel\"]"}, | ||
| {"name":"metrics-completeness","status":"pass","score":0,"max":0,"detail":"17/17 instruments per ADR-008 table"}, | ||
| {"name":"exporter","status":"pass","score":0,"max":0,"detail":"OTLP gRPC via grpc-tonic"}, | ||
| {"name":"shutdown-graceful","status":"pass","score":0,"max":0,"detail":"TelemetryGuard flushes tracer + meter on drop"}, | ||
| {"name":"build","status":"pass","score":2,"max":2,"detail":"cargo check --workspace succeeds (Rust 1.96)"}, | ||
| {"name":"test-unit","status":"pass","score":3,"max":3,"detail":"cargo test (config tests, metrics construct, span no-panic)"}, | ||
| {"name":"fmt","status":"pass","score":2,"max":2,"detail":"cargo fmt --check passes"}, | ||
| {"name":"clippy","status":"pass","score":2,"max":2,"detail":"cargo clippy --workspace --all-targets --all-features -- -D warnings"}, | ||
| {"name":"doc","status":"pass","score":1,"max":1,"detail":"cargo doc --workspace --no-deps"} | ||
| ], | ||
| "timestamp": "2026-06-25T22:55:00Z" | ||
| "findings": [ | ||
| { | ||
| "severity": "info", | ||
| "file": "crates/byteport-otel/src/init.rs:57-60", | ||
| "rule_id": "kilo-style", | ||
| "message": "OTLP init failure falls back to stdout — acceptable for dev, consider feature-gating in production" | ||
| }, | ||
| { | ||
| "severity": "info", | ||
| "file": "crates/byteport-otel/src/metrics.rs:41", | ||
| "rule_id": "kilo-style", | ||
| "message": "BytePortMetrics::new() returns Result — with no backend it succeeds via no-op meter; fine for current use" | ||
| }, | ||
| { | ||
| "severity": "info", | ||
| "file": "crates/byteport-transport/Cargo.toml:15", | ||
| "rule_id": "kilo-style", | ||
| "message": "otel feature pulls in byteport-otel with heavy deps — gating is correct, consumers can opt-out with default-features = false" | ||
| }, | ||
| { | ||
| "severity": "warn", | ||
| "file": "crates/byteport-otel/src/tracing.rs:18-32", | ||
| "rule_id": "kilo-sota", | ||
| "message": "start_request_span takes TracerProvider impl (ADR-008 used global tracer) — acceptable trade-off for testability" | ||
| } | ||
| ], | ||
| "timestamp": "2026-06-26T02:50:00Z" | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new dependencies are not reflected in the committed lockfile: in this commit
Cargo.lockstill has nobyteport-otel,opentelemetry, ortracing-opentelemetrypackage entries, and thebyteport-clipackage entry still lists onlybyteport-transportandclap. Any clean checkout usingcargo --locked/CI will fail before compiling because the manifest and lockfile disagree, so the lockfile needs to be regenerated with these dependency edges included.Useful? React with 👍 / 👎.