feat(E8): add OTel context propagation to spawned child processes by KooshaPari · Pull Request #256 · KooshaPari/BytePort

KooshaPari · 2026-06-26T04:27:44Z

Summary

Add OTel context propagation to child processes spawned by BytePort CLI and Go backend, enabling end-to-end distributed tracing across process boundaries.

Context

BytePort's OTel instrumentation (E6/E7/E9) added tracing and metrics within the Rust CLI process, but trace context was lost when spawning child processes (e.g., git ls-remote for repo validation). This created gaps in the trace tree, making it impossible to correlate parent-spawn operations.

Changes

Rust (byteport-otel/src/propagation.rs) — New module with:
- current_context_envs() — injects W3C trace context into env pairs
- propagate_to_cmd() / propagate_to_tokio_cmd() — convenience wrappers for std::process::Command and tokio::process::Command
- EnvSetter trait for extensible env injection
- Unit tests for no-op and active-span scenarios
Rust (init.rs) — Register global TraceContextPropagator in init_telemetry()
Go (backend/byteport/lib/otelpropagation.go) — New helper PropagateContextToCmd() for Go exec.Cmd
Go (backend/byteport/lib/apilink.go) — Wire propagation into ValidateGitRepo() (spawns git ls-remote)
Go (backend/byteport/main.go) — Register W3C propagation.TraceContext{} as global propagator

Use Cases

ValidateGitRepo: git ls-remote spawn now carries the parent HTTP request's trace context
Any future exec.Command calls in the Go backend inherit tracing
Rust CLI commands that spawn subprocesses (build, deploy, sidecar) are automatically linked

Testing

# Rust unit tests
cargo test -p byteport-otel propagation

# Go build
cd backend/byteport && go build ./...

# Manual verification — set OTEL_TRACES_EXPORTER=otlp and observe
# TRACEPARENT env var in spawned process

Links

DAG unit: E8 (compute/infra epic)
Prior work: E6 (byteport-otel crate), E7 (CLI tracing), E9 (CLI metrics)

…teport-otel)

gemini-code-assist · 2026-06-26T04:27:47Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

github-actions · 2026-06-26T04:27:59Z

Legacy Tooling Scan Report

Severity	Count
Critical	0
High	0
Medium	0
Low	0

No violations detected.

This is a WARN-mode scan. Fix before strict enforcement begins.

socket-security · 2026-06-26T04:28:04Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	cargo/futures@0.3.32
	cargo/rayon@1.10.0
	cargo/tempfile@3.27.0

View full report

sonarqubecloud · 2026-06-26T04:28:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92dfb0f662

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-26T04:32:06Z

+    Ok(TracerProvider::builder()
+        .with_batch_exporter(exporter, opentelemetry_sdk::runtime::Tokio)


Run OTLP initialization inside a Tokio runtime

When byteport-cli calls init_default() from its synchronous main (crates/byteport-cli/src/main.rs:108), this constructs the gRPC OTLP batch processor with the Tokio runtime even though no Tokio runtime has been entered. In normal CLI invocations that can panic during telemetry startup before any codec, transport, ui, or upload command runs; use a blocking/simple exporter for the CLI or initialize telemetry from an async Tokio runtime.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-26T04:32:06Z

+    let _otel_guard = byteport_otel::init::init_default();
+    info!("byteport-cli starting");


Send CLI telemetry logs somewhere other than stdout

byteport-cli uses stdout as its command output channel, but main now calls init_default() before parsing commands and the default config enables JSON fmt logging to stdout. With the new info! calls this means commands like codec encode hello no longer emit just 68656c6c6f; they are wrapped with log records, which breaks scripts/tests that consume the CLI output. Disable stdout logging by default for the CLI or write telemetry logs to stderr/a file.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-26T04:32:06Z

+	// Propagate OTel trace context to the child process so that
+	// git operations are linked to the parent trace.
+	PropagateContextToCmd(context.Background(), cmd)


Pass the active context into propagation

This always injects from context.Background(), which has no active span, so PropagateContextToCmd has no parent trace context to serialize and the spawned git ls-remote process will not be linked to the request/operation trace. In the path that validates a repo, thread the caller's request context into ValidateGitRepo and pass that context here instead of creating a fresh background context.

Useful? React with 👍 / 👎.

kilo-code-bot · 2026-06-27T15:03:35Z

Code Review Summary

Status: 3 Issues Found | Recommendation: Address before merge

Overview

This PR adds OTel context propagation to child processes for end-to-end distributed tracing. The core concept is sound, but there are implementation issues that need fixing.

Severity	Count
CRITICAL	1
WARNING	1
SUGGESTION	1

Issue Details (click to expand)

CRITICAL

File	Line	Issue
`crates/byteport-otel/src/propagation.rs`	44	`inject()` call missing context argument - OpenTelemetry 0.28 API requires `&Context` as first parameter

WARNING

File	Line	Issue
`crates/byteport-otel/src/init.rs`	57-61	`set_text_map_propagator` called inside `if config.enable_tracing` block - propagation won't work for metrics-only configuration

SUGGESTION

File	Line	Issue
`backend/byteport/lib/otelpropagation.go`	2-3	Function name `PropagateContextToCmd` uses PascalCase (Go convention is camelCase for function names)

Files Reviewed (7 files)

crates/byteport-otel/src/propagation.rs - CRITICAL: inject API misuse (lines 44, 139)
crates/byteport-otel/src/init.rs - WARNING: propagator registration scope
backend/byteport/lib/otelpropagation.go - SUGGESTION: naming convention
backend/byteport/lib/apilink.go - Reviewed (existing P2 issue on context.Background)
backend/byteport/main.go - Reviewed (correct W3C propagator registration)
crates/byteport-cli/src/main.rs - Reviewed (existing P2 issue on stdout logging)
crates/byteport-otel/src/tracing.rs - Reviewed (correct span helpers)

CRITICAL:
propagation.rs:44 - The inject method signature in opentelemetry 0.28 is propagator.inject(&cx, &mut carrier) where cx: &Context. The current code propagator.inject(&mut carrier) is missing the context argument. The context variable cx is defined on line 40 but never passed. This will cause propagation to fail silently or panic.

WARNING:
init.rs:57-61 - The propagator registration is inside the if config.enable_tracing block. If enable_tracing is false but enable_metrics is true, the propagator won't be registered and propagation to child processes will not work.

SUGGESTION:
otelpropagation.go:2-3 - Go convention uses camelCase for function names. PropagateContextToCmd should be propagateContextToCmd or propagateContext to match Go style.

EXISTING ISSUES (already commented):

init.rs:153 - OTLP batch exporter requires Tokio runtime in synchronous CLI main (P1)
main.rs:109 - stdout logging breaks CLI output contract (P2)
apilink.go:271 - context.Background() provides no active span for propagation (P2)

Fix these issues in Kilo Cloud

_{Reviewed by laguna-m.1-20260312:free · Input: 304.8K · Output: 18.2K · Cached: 2.8M}

kilo-code-bot · 2026-06-27T15:04:02Z

+    let mut carrier = Vec::new();
+
+    global::get_text_map_propagator(|propagator| {
+        propagator.inject(&mut carrier);


CRITICAL: Missing context argument in inject() call

The OpenTelemetry 0.28 TextMapPropagator::inject method signature is propagator.inject(cx, carrier). The current code calls propagator.inject(&mut carrier) without a context. The context variable cx is defined on line 40 but never passed to inject. This will cause propagation to fail silently or panic at runtime.

Suggested change

propagator.inject(&mut carrier);

global::get_text_map_propagator(|propagator| {

propagator.inject(&cx, &mut carrier);

});

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

kilo-code-bot · 2026-06-27T15:04:19Z

+        let tracer = provider.tracer("test");
+
+        // We must register the global propagator.
+        opentelemetry::global::set_text_map_propagator(


CRITICAL: Same inject() call missing context in test code

Same issue as line 44 - propagator.inject(&mut carrier) is called without context. This test will not properly verify traceparent injection.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

KooshaPari added 7 commits June 25, 2026 19:09

feat(E6): add byteport-otel crate with metrics, tracing, OTLP export

fb7afdf

fix(E6): remove stale crates/byteport-cli/src/metrics.rs (moved to by…

d44543c

…teport-otel)

feat(E9): add OTel metrics for CLI invocation rate/error

b19a24a

chore(E6): add grade report for OTel instrumentation review

9c07b75

feat(E7): add OTel tracing to CLI command lifecycle

2d7fd86

chore(E7): append grade report and worklog audit entry

96f83e7

feat(E8): add OTel context propagation to spawned child processes

92dfb0f

KooshaPari added the area:compute-infra Phenotype compute/infra epic label Jun 26, 2026

chatgpt-codex-connector Bot reviewed Jun 26, 2026

View reviewed changes

kilo-code-bot Bot reviewed Jun 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(E8): add OTel context propagation to spawned child processes#256

feat(E8): add OTel context propagation to spawned child processes#256
KooshaPari wants to merge 7 commits into
mainfrom
feat/E8-otel-context-propagate

KooshaPari commented Jun 26, 2026

Uh oh!

gemini-code-assist Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

socket-security Bot commented Jun 26, 2026

Uh oh!

sonarqubecloud Bot commented Jun 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 26, 2026

Uh oh!

chatgpt-codex-connector Bot Jun 26, 2026

Uh oh!

chatgpt-codex-connector Bot Jun 26, 2026

Uh oh!

kilo-code-bot Bot commented Jun 27, 2026 •

edited

Loading

CRITICAL

WARNING

SUGGESTION

Uh oh!

kilo-code-bot Bot Jun 27, 2026

Uh oh!

kilo-code-bot Bot Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		Ok(TracerProvider::builder()
		.with_batch_exporter(exporter, opentelemetry_sdk::runtime::Tokio)

		let _otel_guard = byteport_otel::init::init_default();
		info!("byteport-cli starting");

Conversation

KooshaPari commented Jun 26, 2026

Summary

Context

Changes

Use Cases

Testing

Links

Uh oh!

gemini-code-assist Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

socket-security Bot commented Jun 26, 2026

Uh oh!

sonarqubecloud Bot commented Jun 26, 2026

Quality Gate passed

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot Bot commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Overview

CRITICAL

WARNING

SUGGESTION

Uh oh!

kilo-code-bot Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot Bot Jun 27, 2026

Choose a reason for hiding this comment

Same issue as line 44 - propagator.inject(&mut carrier) is called without context. This test will not properly verify traceparent injection.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kilo-code-bot Bot commented Jun 27, 2026 •

edited

Loading

Same issue as line 44 - `propagator.inject(&mut carrier)` is called without context. This test will not properly verify traceparent injection.