Skip to content

chore: bootstrap FUNDING.yml and trufflehog.yml#35

Closed
KooshaPari wants to merge 2 commits into
mainfrom
bootstrap/codeowners
Closed

chore: bootstrap FUNDING.yml and trufflehog.yml#35
KooshaPari wants to merge 2 commits into
mainfrom
bootstrap/codeowners

Conversation

@KooshaPari

@KooshaPari KooshaPari commented May 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bootstrap FUNDING.yml for GitHub Sponsors
  • Bootstrap trufflehog.yml secrets scanning workflow

Test plan

  • Verify FUNDING.yml appears on repo's Funding tab
  • Verify trufflehog workflow runs on push/PR

Note

Low Risk
Low risk repo-metadata changes plus a small Rust/PyO3 type-alias refactor for the audit return type; no behavior or data-flow changes expected.

Overview
Adds repo-level maintenance files: CODEOWNERS (default owner), FUNDING.yml (GitHub Sponsors + custom link), and trufflehog.yml configuration for secrets scanning with common path excludes.

In the Python FFI adapter (crates/pheno-ffi-python/.../mod.rs), introduces an AuditRecord type alias and updates PhenoConfig.audit to return Vec<AuditRecord> instead of an inline tuple type (no functional change).

Reviewed by Cursor Bugbot for commit be00de9. Bugbot is set up for automated code reviews on this repo. Configure here.

Phenotype Agent and others added 2 commits May 2, 2026 06:20
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add AuditRecord type alias for the 5-tuple return type in Python
bindings audit() method to satisfy clippy::type_complexity.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 2, 2026 20:55
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit be00de9. Configure here.

Comment thread FUNDING.yml
@@ -0,0 +1,3 @@
github: [KooshaPari]
custom: ["https://kooshapari.com/sponsor"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FUNDING.yml placed at root instead of .github directory

Medium Severity

FUNDING.yml is placed at the repository root, but GitHub only recognizes it inside the .github/ directory. A valid .github/FUNDING.yml already exists with different content (different sponsor links). This root-level file will have no effect — the PR test plan item "Verify FUNDING.yml appears on repo's Funding tab" will pass only because of the pre-existing .github/FUNDING.yml, not this new file.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit be00de9. Configure here.

Comment thread CODEOWNERS
@@ -0,0 +1,2 @@
# Default owners
* @KooshaPari

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root CODEOWNERS is ignored due to .github precedence

Low Severity

A root-level CODEOWNERS is added, but .github/CODEOWNERS already exists with more detailed ownership rules. GitHub checks .github/ first and ignores any other CODEOWNERS file. This root-level file is completely inert and could confuse contributors about which file is authoritative.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit be00de9. Configure here.

Comment thread trufflehog.yml
- "**/.git/**"
detectors:
- allowlist: false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trufflehog.yml config not referenced by existing workflow

Medium Severity

This root-level trufflehog.yml is a scanner configuration file, but TruffleHog does not auto-discover config files — they must be explicitly passed via --config. The existing workflow at .github/workflows/trufflehog.yml runs trufflehog github --only-verified --no-update without a --config flag, so these settings (scan_depth, exclude_paths, detectors) are never applied.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit be00de9. Configure here.

@KooshaPari KooshaPari closed this May 2, 2026
@KooshaPari KooshaPari deleted the bootstrap/codeowners branch May 2, 2026 21:03
@KooshaPari KooshaPari removed the request for review from Copilot May 2, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant