Skip to content
This repository was archived by the owner on Jun 26, 2026. It is now read-only.

feat(consolidate): heliosBench integration/consolidate#176

Open
KooshaPari wants to merge 2 commits into
mainfrom
integration/consolidate
Open

feat(consolidate): heliosBench integration/consolidate#176
KooshaPari wants to merge 2 commits into
mainfrom
integration/consolidate

Conversation

@KooshaPari

Copy link
Copy Markdown
Owner

Block B consolidation PR — Python benchmark tool. CI must pass before merge.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md file by adding a work-state comment at the top to track the progress of Block B consolidation. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

…ations

- journey-gate: install phenotype-journey from git repo instead of non-existent reusable workflow
- trufflehog: inline TruffleHog secrets scanning instead of calling missing reusable workflow

The phenotype-tooling reusable workflows (reusable-journey-gate.yml, reusable-trufflehog.yml) do not exist;
inline versions use standard actions (rust-toolchain, trufflehog@main) with explicit parameters.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

@KooshaPari KooshaPari marked this pull request as ready for review June 16, 2026 03:23
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Comment thread .github/workflows/journey-gate.yml
Comment thread .github/workflows/journey-gate.yml
Comment thread .github/workflows/journey-gate.yml
Comment thread .github/workflows/trufflehog.yml
Comment thread .github/workflows/trufflehog.yml
Comment thread README.md
@kilo-code-bot

kilo-code-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 2 Issues Found | Recommendation: Request Changes

Overview

Severity Count
CRITICAL 2
WARNING 2
SUGGESTION 2

Headline issues:

  • The new journey-gate.yml is effectively a no-op: it installs Rust toolchain in a Python repo and iterates an empty journeys/*.toml glob, so it always passes.
  • Both new workflow files pin to mutable refs (@main) for third-party actions / crates — supply-chain risk.

Issue Details

File Line Severity Issue
.github/workflows/journey-gate.yml 19 WARNING Rust toolchain installed in a Python-only repo; Swatinem/rust-cache is a no-op.
.github/workflows/journey-gate.yml 24 WARNING cargo install --git ... with mutable main ref, no --locked/SHA pin.
.github/workflows/journey-gate.yml 28 CRITICAL journeys/*.toml matches zero files in this repo; gate is silently vacuous.
.github/workflows/trufflehog.yml 23 CRITICAL trufflesecurity/trufflehog@main is a mutable ref — supply-chain risk.
.github/workflows/trufflehog.yml 28 SUGGESTION --only-verified silently drops unverified findings.
README.md 1 SUGGESTION Internal work-state progress marker leaked into user-facing README.
Other Observations (not in diff)
  • __pycache__ files committed to the repo (4 new .pyc files under src/helios_bench/__pycache__/ and tests/__pycache__/). These are build artifacts and should be gitignored, not committed. Add __pycache__/ and *.pyc to .gitignore and remove the tracked files.
  • Existing .gitignore is minimal and does not cover Python artifacts at all, which is why they were committed in the first place. Worth fixing in this PR.
  • No journeys/ directory exists in the repository — the phenotype-journey install + for file in journeys/*.toml loop will silently iterate nothing in the current tree. Either add the journey files or remove the gate.
  • SonarCloud quality gate is currently failing on this PR (3 Security Hotspots per the bot comment), independent of the diff here — the workflow changes do not address it.
Files Reviewed (7 files)
  • .github/workflows/journey-gate.yml - 3 issues
  • .github/workflows/trufflehog.yml - 2 issues
  • README.md - 1 issue
  • src/helios_bench/__pycache__/__init__.cpython-313.pyc - 0 issues (binary, artifact)
  • src/helios_bench/__pycache__/tasks.cpython-313.pyc - 0 issues (binary, artifact)
  • tests/__pycache__/test_benchmark.cpython-313-pytest-9.1.0.pyc - 0 issues (binary, artifact)
  • tests/__pycache__/test_benchmark.cpython-314-pytest-9.1.0.pyc - 0 issues (binary, artifact)

Recommendation

Request changes. The most blocking issues:

  1. Either add journey files or remove the journey-gate.yml workflow — a vacuous gate is worse than no gate.
  2. Pin all third-party actions and git-installed crates to immutable refs (commit SHAs or release tags).
  3. Stop committing __pycache__/ artifacts; update .gitignore.

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · 155,681 tokens

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant