Repository navigation
test: skip AlphaPulldown's own subfolders when the GPU checks look for folds - #667
Merged
Merged
Conversation
…r folds With the alphapulldown/ and debug/ subfolders (#664), a fold written straight into the output directory (run_structure_prediction.py, as the AF2 long-name check does) has subfolders that are not folds. The AF2 and AlphaLink checks took every subfolder for a fold, so TestRunModes::test__long_name found no ranked models in alphapulldown/ and failed on main 228c5ee. The AF3 checks already pick fold folders by their ranking_scores.csv. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the full AF2 GPU suite on
main(228c5eed):TestRunModes::test__long_namefailed with0 != 5ranked models.alphapulldown/anddebug/subfolders from feat: keep AlphaPulldown's own files in alphapulldown/ and debug/ #664, a fold written straight into the output directory has subfolders that are not folds.run_structure_prediction.pydoes that, as the long-name check uses it. The AF2 check (and the same pattern in two AlphaLink checks) took every subfolder for a fold.ranking_scores.csv.Validation: the failed test reruns on the same setup, and the 2.11.0 release check runs the full AF2 suite with this fix.
🤖 Generated with Claude Code