Repository navigation
test: drop the duplicate compile-cache flag check - #62
Merged
Merged
Conversation
test_jax_cache_dir_accepted_on_af2 repeated the AlphaFold 2 half of test_inference_flag_tables.test_jax_compile_cache_is_valid_on_both_backends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a review of the test suites for duplicates.
test_unknown_inference_flags.py::test_jax_cache_dir_accepted_on_af2repeated the AlphaFold 2 half oftest_inference_flag_tables.py::test_jax_compile_cache_is_valid_on_both_backends, which checks both backends. This PR removes the duplicate.Reviewed and kept:
test_mmseqs2_features.pyis long, but every test in it covers the local MMseqs2 feature mode (adapter, cache keys, shard planning, real dry runs). Its startup-logging tests check real dry-run logs of that mode, a different layer fromtest_length_startup.py's lookup-cache tests, so nothing there is duplicated.test_unknown_inference_flags.pyandtest_inference_flag_tables.py: 12 passed, 1 skipped (the AlphaPulldown comparison, which needs AlphaPulldown importable).🤖 Generated with Claude Code