fix(ci): skip Slack notify steps when SLACK_WEBHOOK_URL is unset - #431
Closed
tommaso-castellani wants to merge 1 commit into
Closed
fix(ci): skip Slack notify steps when SLACK_WEBHOOK_URL is unset#431tommaso-castellani wants to merge 1 commit into
tommaso-castellani wants to merge 1 commit into
Conversation
The three notify steps curl ${{ secrets.SLACK_WEBHOOK_URL }} unguarded. This repo
has the secret so it stays green, but every repo cloned from this template does
not: the URL expands to empty, curl exits 2 ('no URL specified'), and the run is
marked failed even when the shadcn update succeeded. Guard each step on a
non-empty webhook and quote the URL.
nsosio
reviewed
Jul 14, 2026
nsosio
left a comment
Collaborator
There was a problem hiding this comment.
do we still use this flow? can we drop it completely?
Contributor
Author
|
Superseded — @nsosio asked to drop the shadcn workflow from the template entirely, so guarding the Slack steps is moot here. Closing in favour of a PR that removes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The three
Notify Slacksteps in.github/workflows/shadcn.ymlcurl the webhook unguarded:This repo has
SLACK_WEBHOOK_URLset, so it stays green and the bug is invisible here. Every repo cloned from this template does not have it. There, the URL expands to nothing, curl exits 2 (curl: (2) no URL specified), and the run is marked failed — even when the shadcn update itself worked perfectly.Four downstream repos have been failing this way every single day for over a week (
template-test,template-clone,cardinal-core-sync-replay,dive-the-plan). Ontemplate-testthe workflow did its whole job correctly, found an already-open PR, and then died posting to Slack.Fix
env.SLACK_WEBHOOK_URL.env.SLACK_WEBHOOK_URL != ''so it self-skips when the secret is absent.Behaviour in this repo is unchanged (the secret is set, so all three steps still fire). Repos without the secret now simply skip the notification instead of failing the run.
Same patch already applied to
tommaso-castellani/dive-the-plan.