Skip to content

fix(map): keep Path Inspector candidates accessible and cover route replacement - #2082

Merged
efiten merged 5 commits into
Kpa-clawbot:masterfrom
n30nex:codex/path-inspector-fixture
Sep 30, 2026
Merged

efiten merged 5 commits into
Kpa-clawbot:masterfrom
n30nex:codex/path-inspector-fixture

Conversation

@n30nex

@n30nex n30nex commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Fix

Fixes #2060. Fixes #2081.

Path Inspector route drawing and candidate replacement now have deterministic browser coverage. An idempotent SQL seed adds four synthetic repeaters and four edges after fixture migration, without changing packet ordering. The test uses the real API, normal clicks, visible Leaflet geometry, and removal of every previous route object.

Restoring coverage exposed a desktop layout bug: drawing the first route moved the map over the next candidate button. The route sidebar now participates in the existing flex layout, including resizing and collapse, while preserving the mobile bottom sheet.

The historical zero-candidate result did not reproduce on the current baseline. No search thresholds or API behavior changed. No new dependencies or customizer settings.

Validation

Local browser validation used Chromium with a 60-second navigation budget; the OpenClaw profile and external preflight script were unavailable. Repository checks ran directly. CI run 36343343569 records the initial assertion-red commit. Final CI must pass before merge.

@n30nex
n30nex marked this pull request as ready for review September 27, 2026 19:32
@n30nex

n30nex commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

Review feedback addressed (commit adfc1e6):

  1. A saved 700px sidebar now yields space at 900px and 768px; native resize, collapse and restore are covered.
  2. Both candidates must draw visible SVG segments at the expected coordinates, and switching removes every previous route object.
  3. Mobile tests verify expanded and collapsed sheet/map geometry.

Parent validation: 183 standalone suites, 11 focused browser checks, 33 related map checks; core E2E 131 passed with 3 existing fixture skips. CI run 36343343569 confirmed the initial candidate-count assertion failed before the seed. The final-head CI run is pending.

@efiten
efiten merged commit 093e320 into Kpa-clawbot:master Sep 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants