Conversation
|
Review feedback addressed (commit
Protocol and adversarial reviews found no production defects. Parent validation passed all 183 standalone suites and the complete core browser suite (133 passed, three existing fixture skips). Real API checks covered the desktop pane/full page and mobile full page. CI run 36353796690 recorded the expected five assertion failures before implementation; final-head CI is running. |
|
CI feedback addressed (commit
The earlier local checklist missed the complete ESLint gate; it is now included in validation. This changes only the two call sites and preserves the reviewed behavior. |
|
I think there is one correctness gap in the classifier that is worth addressing before merge.
MeshCore's packet hash excludes the route header and path, so the same advert payload can be observed on different routes over time—for example, first as zero-hop and later as flood. In that case, the transmission retains the first-ingested routing evidence, so the UI will show the advert in only one group even though it was also seen on the other route. This makes the result dependent on ingestion order and can under-report flood airtime. The fallback that combines the transmission's The current tests use a different hash for every routing case, so they do not cover this scenario. I suggest adding a regression test where the same advert hash is received through both direct/zero-hop and flood routing, and classifying from accumulated per-transmission route evidence. Such a record should either be shown as The wire-format parsing itself looks sound and matches the referenced MeshCore firmware; my concern is specifically the loss of later route evidence after transmission deduplication. |
|
Review feedback addressed (commit
This remains draft until backend #2088 lands. Its upgrade-time preservation correction is still under review; final-head CI is running. |
Fixes #2073. Depends on backend support in #2088; keep this draft until that change lands.
Recent Adverts now groups the bounded sample in both node views as Flood, Mixed flood / zero-hop, Zero-hop, or Other / unknown. Each advert appears once, preserving reception metadata, ordering, packet links, sample counts and existing origin explanations.
The classifier consumes authoritative
advert_kindfrom accumulated server evidence. It no longer guesses from the first stored frame or combines fields from different observations. Missing or unrecognized evidence stays unknown. The heading explains that older history may be incomplete.Red correction:
766a87d(four assertion failures); green correction:8edf36c.Validation
8edf36c(run), including browsers and both container architectures.Grouping is O(n) over at most 20 adverts. No additional requests, dependencies, configuration or theme values. OpenClaw browser profile was unavailable; local Chromium validation was used.