fix: retry who's-watching suppression if localStorage isn't ready yet - #653
Open
KrX3D wants to merge 1 commit into
Open
fix: retry who's-watching suppression if localStorage isn't ready yet#653KrX3D wants to merge 1 commit into
KrX3D wants to merge 1 commit into
Conversation
Reported on-device (standalone, Tizen 6.5): after a full TV power cycle, the app sometimes lands on the profile-selector screen instead of resuming video playback. Not confirmed via a log yet (no direct evidence of the exact mechanism), but this is a plausible, testable cause: disableWhosWatching() only ever ran once, synchronously, at script load, bailing out immediately with just a console warning if YouTube's own recurring_actions localStorage key wasn't there yet. A power cycle is a much slower cold boot than a simple app restart — a genuine race against YouTube's own code creating that key exists on a cold boot that doesn't exist on a warm restart (where the key already exists from before). Now retries up to 10 times, 500ms apart, before giving up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary