Repository navigation
Make Hermes issue work end-to-end with autonomous review loops - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delegation.modelfor reviewer children.Issue
Closes #10
Design / Decisions
The workflow remains flat (
parent -> leaf) and compatible withmax_spawn_depth: 1. Withdelegation.worktree_isolation: true, reviewer children branch from currentHEAD, so the parent commits the exact review target before dispatching review. Reviewer children report findings; the parent evaluates and applies fixes on the primary feature branch. This avoids needless child-branch integration for read-only review.The convergence guard is three review/fix rounds. If a real blocker or semantic disagreement remains after that, the PR stays not-ready and only the unresolved decision is escalated.
Concrete model/provider IDs remain user-runtime choices, not repository architecture.
Validation
.hermes.mdanddocs/AGENT_OPERATING_MODEL.md.main.No product test suite was run because this PR changes only agent workflow documentation.
Remaining / Follow-ups
delegation.model/delegation.providerif a heterogeneous parent/reviewer workflow is desired.Handoff
Branch:
agent/10-autonomous-review-loopA fresh reviewer should read Issue #10,
.hermes.md,docs/AGENT_OPERATING_MODEL.md, and this PR; verify the autonomous review loop is internally consistent with worktree isolation and the no-unapproved-merge boundary. Do not merge without explicit user authorization.