Macro base values: per-100g contract for photo saveMeal and search quantity - #23
Merged
Merged
Conversation
saveMeal wrote base_* from Gemini's per-detected-portion values directly, violating the per-100g data contract. Extract toPer100g() (same rounding as saveAsCustomFood) and reuse in both. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
FoodSearchInput.handleSelect multiplied per-100g macros by quantity before handing them to callers, so every consumer's "base" values were actually base*qty. Pass raw per-100g macros + quantity instead; move the multiply into consumers (MealForm, PhotoMealUpload) so portion_size = qty*100 and shown totals = base*qty per the data contract. ReplaceFoodModal already ignored quantity, so it's correct as-is. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
Data contract: meal_components.base_* is always per 100 g; portion_size is grams eaten.
Existing corrupted rows are tracked in #19 (no migration here).
🤖 Generated with Claude Code