Skip to content

Register: restore login link for OAuth already-exists error; move helpers to registerHelpers.js - #27

Open
KrishP147 wants to merge 1 commit into
mainfrom
krish/fix-signup-review-followups
Open

KrishP147 wants to merge 1 commit into
mainfrom
krish/fix-signup-review-followups

Conversation

@KrishP147

Copy link
Copy Markdown
Owner

Follow-up to #4 / PR #25 (verifier findings).

  • Regression fix: App.jsx OAuth block_existing sends users to /register with an already-exists message; after Sign-up with existing email: clear duplicate error instead of false success #25 that message no longer showed the login link (errorKind was null). The mount effect now marks it duplicate. Test added.
  • Moved isExistingAccount / EXISTING_ACCOUNT_AGE_MS / DUPLICATE_ACCOUNT_MESSAGE to frontend/src/utils/registerHelpers.js (mirrors authHelpers.js) and removed the file-level eslint-disable.

Related: #26 (client-clock dependency in isExistingAccount).

🤖 Generated with Claude Code

…nk for OAuth dup error

Drops file-level react-refresh eslint-disable. OAuth block_existing msg lost its
login link in #25 (errorKind null); set 'duplicate' when msg says 'already exists'.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nutrisync-frontend Ready Ready Preview Sep 24, 2026 3:15am UTC

Copilot AI lite review requested due to automatic review settings September 24, 2026 03:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

This branch was successfully deployed

1 active deployment
Preview — b63c4e6c Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants