WIP: initial form component commit - #2
Open
alexander2402 wants to merge 5 commits into
Open
Conversation
Kronenberg
changed the title
Kronenberg
reviewed
Dec 30, 2018
| <window_info anchor="bottom" id="Find" order="1" /> | ||
| <window_info anchor="bottom" id="Run" order="2" /> | ||
| <window_info anchor="bottom" id="Debug" order="3" weight="0.4" /> | ||
| <window_info anchor="bottom" id="Cvs" order="4" weight="0.25" /> |
| import logo from './logo.svg'; | ||
| import './App.css'; | ||
| import Form from './components/form/' | ||
| import 'bootstrap/dist/css/bootstrap.css'; |
Owner
There was a problem hiding this comment.
don't use bootstrap please !
only display:flex
| _onChangeInputConPass = (e) => { | ||
| const {value} = e.target; | ||
| this.setState({inputConPass: value}); | ||
| }; |
Owner
There was a problem hiding this comment.
all your actions do same job, am i right?
create one action for all the fields
this article might help you: https://reactjs.org/docs/forms.html
| return ( | ||
| <div className="App"> | ||
| <Form | ||
| inputName={this.state.inputName} |
Owner
There was a problem hiding this comment.
i dont need action for every input field, as i told before it should we one method
| } = this.props; | ||
|
|
||
| return ( | ||
| <div className='container formmasa'> |
| // console.log(this.state); | ||
| return ( | ||
| <div className="App"> | ||
| <Form |
Owner
There was a problem hiding this comment.
make this form reusable, provide few examples how i can use your form component for login and logout page's
| render() { | ||
| const { | ||
| inputName, inputSurName, inputEmail, inputPass, inputConPass, change1, change2, change3, | ||
| change4, change5, formValid |
Owner
There was a problem hiding this comment.
change 4 change 5? 👎 proper names
| <input className="form-control mt-3 mb-4 ml-2 col-5" | ||
| placeholder="Surname" | ||
| value={inputSurName} | ||
| onChange={change2}/> |
| <input className="form-control mt-3 mb-4 ml-4 col-5" | ||
| placeholder="Name" | ||
| value={inputName} | ||
| onChange={change1}/> |
| </div> | ||
| </div> | ||
| </div> | ||
| <div className='col-6 mt-5'> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
created few directories:
added empty component "form"